mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-14 04:51:52 +00:00
6507d23e29
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run
With this change we save a copy of of scroll state at the time of recording a display list, instead of actual ScrollState pointer that could be modifed by the main thread while display list is beings rasterized on the rendering thread, which leads to a frame painted with inconsistent scroll state. Fixes https://github.com/LadybirdBrowser/ladybird/issues/4288
95 lines
2.5 KiB
C++
95 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) 2024-2025, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/NonnullOwnPtr.h>
|
|
#include <LibWeb/Painting/ScrollFrame.h>
|
|
|
|
namespace Web::Painting {
|
|
|
|
class ScrollStateSnapshot {
|
|
public:
|
|
static ScrollStateSnapshot create(Vector<NonnullRefPtr<ScrollFrame>> const& scroll_frames);
|
|
|
|
CSSPixelPoint cumulative_offset_for_frame_with_id(size_t id) const
|
|
{
|
|
if (id >= entries.size())
|
|
return {};
|
|
return entries[id].cumulative_offset;
|
|
}
|
|
|
|
CSSPixelPoint own_offset_for_frame_with_id(size_t id) const
|
|
{
|
|
if (id >= entries.size())
|
|
return {};
|
|
return entries[id].own_offset;
|
|
}
|
|
|
|
private:
|
|
struct Entry {
|
|
CSSPixelPoint cumulative_offset;
|
|
CSSPixelPoint own_offset;
|
|
};
|
|
Vector<Entry> entries;
|
|
};
|
|
|
|
class ScrollState {
|
|
public:
|
|
NonnullRefPtr<ScrollFrame> create_scroll_frame_for(PaintableBox const& paintable_box, RefPtr<ScrollFrame const> parent)
|
|
{
|
|
auto scroll_frame = adopt_ref(*new ScrollFrame(paintable_box, m_scroll_frames.size(), false, move(parent)));
|
|
m_scroll_frames.append(scroll_frame);
|
|
return scroll_frame;
|
|
}
|
|
|
|
NonnullRefPtr<ScrollFrame> create_sticky_frame_for(PaintableBox const& paintable_box, RefPtr<ScrollFrame const> parent)
|
|
{
|
|
auto scroll_frame = adopt_ref(*new ScrollFrame(paintable_box, m_scroll_frames.size(), true, move(parent)));
|
|
m_scroll_frames.append(scroll_frame);
|
|
return scroll_frame;
|
|
}
|
|
|
|
CSSPixelPoint cumulative_offset_for_frame_with_id(size_t id) const
|
|
{
|
|
return m_scroll_frames[id]->cumulative_offset();
|
|
}
|
|
|
|
CSSPixelPoint own_offset_for_frame_with_id(size_t id) const
|
|
{
|
|
return m_scroll_frames[id]->own_offset();
|
|
}
|
|
|
|
template<typename Callback>
|
|
void for_each_scroll_frame(Callback callback) const
|
|
{
|
|
for (auto const& scroll_frame : m_scroll_frames) {
|
|
if (scroll_frame->is_sticky())
|
|
continue;
|
|
callback(scroll_frame);
|
|
}
|
|
}
|
|
|
|
template<typename Callback>
|
|
void for_each_sticky_frame(Callback callback) const
|
|
{
|
|
for (auto const& scroll_frame : m_scroll_frames) {
|
|
if (!scroll_frame->is_sticky())
|
|
continue;
|
|
callback(scroll_frame);
|
|
}
|
|
}
|
|
|
|
ScrollStateSnapshot snapshot() const
|
|
{
|
|
return ScrollStateSnapshot::create(m_scroll_frames);
|
|
}
|
|
|
|
private:
|
|
Vector<NonnullRefPtr<ScrollFrame>> m_scroll_frames;
|
|
};
|
|
|
|
}
|