mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-05-02 09:18:52 +00:00
e6f907a155
Problem:
- Many constructors are defined as `{}` rather than using the ` =
default` compiler-provided constructor.
- Some types provide an implicit conversion operator from `nullptr_t`
instead of requiring the caller to default construct. This violates
the C++ Core Guidelines suggestion to declare single-argument
constructors explicit
(https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c46-by-default-declare-single-argument-constructors-explicit).
Solution:
- Change default constructors to use the compiler-provided default
constructor.
- Remove implicit conversion operators from `nullptr_t` and change
usage to enforce type consistency without conversion.
86 lines
3.1 KiB
C++
86 lines
3.1 KiB
C++
/*
|
|
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright notice, this
|
|
* list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
|
|
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
|
|
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <AK/Function.h>
|
|
#include <LibJS/Runtime/Error.h>
|
|
#include <LibJS/Runtime/GlobalObject.h>
|
|
#include <LibJS/Runtime/Uint8ClampedArray.h>
|
|
#include <string.h>
|
|
|
|
namespace JS {
|
|
|
|
Uint8ClampedArray* Uint8ClampedArray::create(GlobalObject& global_object, u32 length)
|
|
{
|
|
return global_object.heap().allocate<Uint8ClampedArray>(global_object, length, *global_object.array_prototype());
|
|
}
|
|
|
|
Uint8ClampedArray::Uint8ClampedArray(u32 length, Object& prototype)
|
|
: Object(prototype)
|
|
, m_length(length)
|
|
{
|
|
auto& vm = this->vm();
|
|
define_native_property(vm.names.length, length_getter, {});
|
|
m_data = (u8*)calloc(m_length, 1);
|
|
}
|
|
|
|
Uint8ClampedArray::~Uint8ClampedArray()
|
|
{
|
|
ASSERT(m_data);
|
|
free(m_data);
|
|
m_data = nullptr;
|
|
}
|
|
|
|
JS_DEFINE_NATIVE_GETTER(Uint8ClampedArray::length_getter)
|
|
{
|
|
auto* this_object = vm.this_value(global_object).to_object(global_object);
|
|
if (!this_object)
|
|
return {};
|
|
if (StringView(this_object->class_name()) != "Uint8ClampedArray") {
|
|
vm.throw_exception<TypeError>(global_object, ErrorType::NotA, "Uint8ClampedArray");
|
|
return {};
|
|
}
|
|
return Value(static_cast<const Uint8ClampedArray*>(this_object)->length());
|
|
}
|
|
|
|
bool Uint8ClampedArray::put_by_index(u32 property_index, Value value)
|
|
{
|
|
if (property_index >= m_length)
|
|
return Base::put_by_index(property_index, value);
|
|
auto number = value.to_i32(global_object());
|
|
if (vm().exception())
|
|
return {};
|
|
m_data[property_index] = clamp(number, 0, 255);
|
|
return true;
|
|
}
|
|
|
|
Value Uint8ClampedArray::get_by_index(u32 property_index) const
|
|
{
|
|
if (property_index >= m_length)
|
|
return Base::get_by_index(property_index);
|
|
return Value((i32)m_data[property_index]);
|
|
}
|
|
|
|
}
|