mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-10-23 00:19:18 +00:00
2e910dd6e1
We fill these overload sets from vectors, which means that by the time we iterated over them, any semblance of their original ordering was lost. Their ordering is important, because we invoke define_native_function() for them which eventually stores ordered properties. This should not be an issue as long as iterating over a HashMap that was filled in exactly the same way results in the same ordering. However, HashTable utilizes kmalloc_good_size() to determine a good allocation size - and the implementation for kmalloc_good_size() on Linux and macOS differs, causing a different capacity and ordering on those platforms. This was not caught by CI, because we run that with sanitizers enabled which overrides malloc_good_size() on macOS, resulting in the same behavior as on Linux. Change the overload sets to be OrderedHashMaps instead and rebaseline the failing test. |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| ExposedTo.cpp | ||
| ExposedTo.h | ||
| IDLParser.cpp | ||
| IDLParser.h | ||
| Types.cpp | ||
| Types.h | ||