mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-07 01:21:57 +00:00
We were unnecessarily discarding the shadow trees of various elements when they were removed or detached from the DOM. This especially caused a *lot* of churn when creating input elements via setting .innerHTML on something. We ended up building each input element's shadow tree 3 times instead of 1. The original issue that we were trying to solve by discarding shadow trees appears to have been solved elsewhere, and nothing else seems to break by just allowing them to remain in place. 1.05x speedup on Speedometer's TodoMVC-jQuery.
64 lines
1.7 KiB
C++
64 lines
1.7 KiB
C++
/*
|
|
* Copyright (c) 2020-2022, the SerenityOS developers.
|
|
* Copyright (c) 2023, Bastiaan van der Plaat <bastiaan.v.d.plaat@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibWeb/ARIA/Roles.h>
|
|
#include <LibWeb/HTML/HTMLElement.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
class HTMLProgressElement final : public HTMLElement {
|
|
WEB_PLATFORM_OBJECT(HTMLProgressElement, HTMLElement);
|
|
GC_DECLARE_ALLOCATOR(HTMLProgressElement);
|
|
|
|
public:
|
|
virtual ~HTMLProgressElement() override;
|
|
|
|
double value() const;
|
|
WebIDL::ExceptionOr<void> set_value(double);
|
|
|
|
WebIDL::Double max() const;
|
|
WebIDL::ExceptionOr<void> set_max(WebIDL::Double value);
|
|
|
|
double position() const;
|
|
|
|
// ^HTMLElement
|
|
virtual void inserted() override;
|
|
|
|
virtual void adjust_computed_style(CSS::ComputedProperties&) override;
|
|
|
|
// https://html.spec.whatwg.org/multipage/forms.html#category-label
|
|
virtual bool is_labelable() const override { return true; }
|
|
|
|
// https://www.w3.org/TR/html-aria/#el-progress
|
|
virtual Optional<ARIA::Role> default_role() const override { return ARIA::Role::progressbar; }
|
|
|
|
private:
|
|
HTMLProgressElement(DOM::Document&, DOM::QualifiedName);
|
|
|
|
// ^DOM::Node
|
|
virtual bool is_html_progress_element() const final { return true; }
|
|
|
|
virtual void initialize(JS::Realm&) override;
|
|
virtual void visit_edges(Cell::Visitor&) override;
|
|
|
|
void create_shadow_tree_if_needed();
|
|
|
|
void update_progress_value_element();
|
|
|
|
bool is_determinate() const { return has_attribute(HTML::AttributeNames::value); }
|
|
|
|
GC::Ptr<DOM::Element> m_progress_value_element;
|
|
};
|
|
|
|
}
|
|
|
|
namespace Web::DOM {
|
|
template<>
|
|
inline bool Node::fast_is<HTML::HTMLProgressElement>() const { return is_html_progress_element(); }
|
|
}
|