mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-04-25 14:05:15 +00:00
82bac7e665
While the clipping logic was correct (current v/s new clipping path), the clipping path contents weren't. This commit fixed that. We calculate the clipping path in two places: when we set it to be the whole page at graphics state creation time, and when we perform clipping path intersection to calculate a new clipping path. The clipping path is then used to limit painting by passing it to the painter (more precisely, but passing its bounding box to the painter, as the latter doesn't support arbitrary path clipping). For this last point the clipping path must be in device coordinates. There was however a mix of coordinate systems involved in the creation, update and usage of the clipping path: * The initial values of the path (i.e., the whole page) were in user coordinates. * Clipping path intersection was performed against m_current_path, which is in device coordinates. * To perform the clipping operation, the current clipping path was assumed to be in user coordinates. This mix resulted in the clipping not working correctly depending on the zoom level at which one visualised a page. This commit fixes the issue by always keeping track of the clipping path in device coordinates. This means that the initial full-page contents are now converted to device coordinates before putting them in the graphics state, and that no mapping is performed when applied the clipping to the painter. |
||
|---|---|---|
| .. | ||
| Fonts | ||
| CMakeLists.txt | ||
| ColorSpace.cpp | ||
| ColorSpace.h | ||
| CommonNames.cpp | ||
| CommonNames.h | ||
| Document.cpp | ||
| Document.h | ||
| DocumentParser.cpp | ||
| DocumentParser.h | ||
| Encoding.cpp | ||
| Encoding.h | ||
| Encryption.cpp | ||
| Encryption.h | ||
| Error.h | ||
| Filter.cpp | ||
| Filter.h | ||
| Forward.h | ||
| Interpolation.cpp | ||
| Interpolation.h | ||
| Object.h | ||
| ObjectDerivatives.cpp | ||
| ObjectDerivatives.h | ||
| Operator.h | ||
| Parser.cpp | ||
| Parser.h | ||
| Reader.cpp | ||
| Reader.h | ||
| Reference.h | ||
| Renderer.cpp | ||
| Renderer.h | ||
| Value.cpp | ||
| Value.h | ||
| XRefTable.h | ||