mirrors/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-04-20 19:45:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

vk: Lock passthrough DMA behind the async streaming option

Browse source 
- Without async streaming this option can introduce artifacts.
  The correct fix for it is to use async streaming which allows the GPU to process texture data in parallel with rendering.
  Without streaming enabled the GPU can sometimes pull stale data via DMA when rendering and find the CPU has modified it.
This commit is contained in:
kd-11 2021-05-25 19:18:01 +03:00 • committed by kd-11
parent 122bb4d829
commit 156b092dc9
1 changed files with 19 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
rpcs3/Emu/RSX/VK/VKDMA.cpp
View file

@ -256,35 +256,36 @@ namespace vk
void create_dma_block(std::unique_ptr<dma_block>& block, u32 base_address, usz expected_length)
{
const auto vendor = g_render_device->gpu().get_driver_vendor();
[[maybe_unused]] const auto chip = vk::get_chip_family();
bool allow_host_buffers = false;
#if defined(_WIN32)
bool allow_host_buffers;
if (vendor == driver_vendor::NVIDIA)
if (g_cfg.video.vk.asynchronous_texture_streaming)
{
if (g_cfg.video.vk.asynchronous_texture_streaming)
if (vendor == driver_vendor::NVIDIA)
{
allow_host_buffers = (chip != chip_class::NV_mobile_kepler) ?
allow_host_buffers = (vk::get_chip_family() != chip_class::NV_mobile_kepler) ?
test_host_pointer(base_address, expected_length) :
false;
}
else
{
allow_host_buffers = false;
allow_host_buffers = true;
}
#elif defined(__linux__)
// Anything running on AMDGPU kernel driver will not work due to the check for fd-backed memory allocations
allow_host_buffers = (vendor != driver_vendor::AMD && vendor != driver_vendor::RADV);
#else
// Anything running on AMDGPU kernel driver will not work due to the check for fd-backed memory allocations
// Intel chipsets woulf fail in most cases and DRM_IOCTL_i915_GEM_USERPTR unimplemented
allow_host_buffers = (vendor != driver_vendor::AMD && vendor != driver_vendor::RADV && vendor != driver_vendor::INTEL);
#endif
if (!allow_host_buffers)
{
rsx_log.trace("Requested DMA passthrough for block 0x%x->0x%x but this was not possible.",
base_address, base_address + expected_length - 1);
}
}
else
{
allow_host_buffers = true;
}
#elif defined(__linux__)
// Anything running on AMDGPU kernel driver will not work due to the check for fd-backed memory allocations
const bool allow_host_buffers = (vendor != driver_vendor::AMD && vendor != driver_vendor::RADV);
#else
// Anything running on AMDGPU kernel driver will not work due to the check for fd-backed memory allocations
// Intel chipsets woulf fail in most cases and DRM_IOCTL_i915_GEM_USERPTR unimplemented
const bool allow_host_buffers = (vendor != driver_vendor::AMD && vendor != driver_vendor::RADV && vendor != driver_vendor::INTEL);
#endif
if (allow_host_buffers && g_render_device->get_external_memory_host_support())
{
block.reset(new dma_block_EXT());