diff --git a/rpcs3/Emu/Audio/Cubeb/cubeb_enumerator.cpp b/rpcs3/Emu/Audio/Cubeb/cubeb_enumerator.cpp index 877628d5d0..c669d0e87f 100644 --- a/rpcs3/Emu/Audio/Cubeb/cubeb_enumerator.cpp +++ b/rpcs3/Emu/Audio/Cubeb/cubeb_enumerator.cpp @@ -104,7 +104,7 @@ std::vector cubeb_enumerator::get_output_ cubeb_dev_enum.error("cubeb_device_collection_destroy() failed: %i", err); } - std::sort(device_list.begin(), device_list.end(), [](audio_device_enumerator::audio_device a, audio_device_enumerator::audio_device b) + std::sort(device_list.begin(), device_list.end(), [](const audio_device_enumerator::audio_device& a, const audio_device_enumerator::audio_device& b) { return a.name < b.name; }); diff --git a/rpcs3/Emu/Audio/XAudio2/xaudio2_enumerator.cpp b/rpcs3/Emu/Audio/XAudio2/xaudio2_enumerator.cpp index 0655f29dca..e170addb0e 100644 --- a/rpcs3/Emu/Audio/XAudio2/xaudio2_enumerator.cpp +++ b/rpcs3/Emu/Audio/XAudio2/xaudio2_enumerator.cpp @@ -144,7 +144,7 @@ std::vector xaudio2_enumerator::get_outpu device_list.emplace_back(dev); } - std::sort(device_list.begin(), device_list.end(), [](audio_device_enumerator::audio_device a, audio_device_enumerator::audio_device b) + std::sort(device_list.begin(), device_list.end(), [](const audio_device_enumerator::audio_device& a, const audio_device_enumerator::audio_device& b) { return a.name < b.name; }); diff --git a/rpcs3/Emu/Io/Dimensions.cpp b/rpcs3/Emu/Io/Dimensions.cpp index a8ef6bc447..158f310bdb 100644 --- a/rpcs3/Emu/Io/Dimensions.cpp +++ b/rpcs3/Emu/Io/Dimensions.cpp @@ -217,7 +217,7 @@ u32 dimensions_toypad::scramble(const std::array& uid, u8 count) return read_from_ptr>(dimensions_randomize(to_scramble, count).data()); } -std::array dimensions_toypad::dimensions_randomize(const std::vector key, u8 count) +std::array dimensions_toypad::dimensions_randomize(const std::vector& key, u8 count) { u32 scrambled = 0; for (u8 i = 0; i < count; i++) diff --git a/rpcs3/Emu/Io/Dimensions.h b/rpcs3/Emu/Io/Dimensions.h index 9cf1bd7395..e4886c11f1 100644 --- a/rpcs3/Emu/Io/Dimensions.h +++ b/rpcs3/Emu/Io/Dimensions.h @@ -49,7 +49,7 @@ private: static std::array generate_figure_key(const std::array& buf); static u32 scramble(const std::array& uid, u8 count); static std::array pwd_generate(const std::array& uid); - static std::array dimensions_randomize(const std::vector key, u8 count); + static std::array dimensions_randomize(const std::vector& key, u8 count); static u32 get_figure_id(const std::array& buf); u32 get_next(); dimensions_figure& get_figure_by_index(u8 index); diff --git a/rpcs3/Emu/Io/PadHandler.h b/rpcs3/Emu/Io/PadHandler.h index 792515c5d8..19178f7682 100644 --- a/rpcs3/Emu/Io/PadHandler.h +++ b/rpcs3/Emu/Io/PadHandler.h @@ -307,7 +307,7 @@ public: }; std::vector& bindings() { return m_bindings; } - std::string name_string() const { return m_name_string; } + const std::string& name_string() const { return m_name_string; } usz max_devices() const { return m_max_devices; } bool has_config() const { return b_has_config; } bool has_rumble() const { return b_has_rumble; } diff --git a/rpcs3/Emu/RSX/VK/vkutils/framebuffer_object.hpp b/rpcs3/Emu/RSX/VK/vkutils/framebuffer_object.hpp index ecafa1d827..03ce077bcc 100644 --- a/rpcs3/Emu/RSX/VK/vkutils/framebuffer_object.hpp +++ b/rpcs3/Emu/RSX/VK/vkutils/framebuffer_object.hpp @@ -75,7 +75,7 @@ namespace vk return attachments.back()->image()->format(); } - bool matches(std::vector fbo_images, u32 width, u32 height) + bool matches(const std::vector& fbo_images, u32 width, u32 height) { if (m_width != width || m_height != height) return false; diff --git a/rpcs3/Emu/RSX/color_utils.h b/rpcs3/Emu/RSX/color_utils.h index 7d315c66ad..55e9e483fd 100644 --- a/rpcs3/Emu/RSX/color_utils.h +++ b/rpcs3/Emu/RSX/color_utils.h @@ -204,7 +204,7 @@ namespace rsx return result; } - static inline u32 encode_color_to_storage_key(color4f color) + static inline u32 encode_color_to_storage_key(const color4f& color) { const u32 r = static_cast(color.r * 255); const u32 g = static_cast(color.g * 255);