From 2ac1ff1d0a6cc7f80c7613c256df60c30d9a4387 Mon Sep 17 00:00:00 2001 From: Ani Date: Sun, 11 Jun 2023 19:58:59 +0100 Subject: [PATCH] Settings: Move Accurate PPU Vector NaN Handling to Debug --- rpcs3/rpcs3qt/settings_dialog.cpp | 6 +++--- rpcs3/rpcs3qt/settings_dialog.ui | 14 +++++++------- rpcs3/rpcs3qt/tooltips.h | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/rpcs3/rpcs3qt/settings_dialog.cpp b/rpcs3/rpcs3qt/settings_dialog.cpp index b918cfbe75..8452b7deae 100644 --- a/rpcs3/rpcs3qt/settings_dialog.cpp +++ b/rpcs3/rpcs3qt/settings_dialog.cpp @@ -1465,9 +1465,6 @@ settings_dialog::settings_dialog(std::shared_ptr gui_settings, std m_emu_settings->EnhanceCheckBox(ui->fixupPPUVNAN, emu_settings_type::FixupPPUVNAN); SubscribeTooltip(ui->fixupPPUVNAN, tooltips.settings.fixup_ppuvnan); - m_emu_settings->EnhanceCheckBox(ui->accuratePPUVNAN, emu_settings_type::AccuratePPUVNAN); - SubscribeTooltip(ui->accuratePPUVNAN, tooltips.settings.accurate_ppuvnan); - m_emu_settings->EnhanceCheckBox(ui->accuratePPUFPCC, emu_settings_type::AccuratePPUFPCC); SubscribeTooltip(ui->accuratePPUFPCC, tooltips.settings.accurate_ppufpcc); @@ -2332,6 +2329,9 @@ settings_dialog::settings_dialog(std::shared_ptr gui_settings, std m_emu_settings->EnhanceCheckBox(ui->accuratePPUNJ, emu_settings_type::AccuratePPUNJ); SubscribeTooltip(ui->accuratePPUNJ, tooltips.settings.accurate_ppunj); + m_emu_settings->EnhanceCheckBox(ui->accuratePPUVNAN, emu_settings_type::AccuratePPUVNAN); + SubscribeTooltip(ui->accuratePPUVNAN, tooltips.settings.accurate_ppuvnan); + m_emu_settings->EnhanceCheckBox(ui->accurateSpuDMA, emu_settings_type::AccurateSpuDMA); SubscribeTooltip(ui->accurateSpuDMA, tooltips.settings.accurate_spu_dma); diff --git a/rpcs3/rpcs3qt/settings_dialog.ui b/rpcs3/rpcs3qt/settings_dialog.ui index 65d06e3994..63b6a26ae3 100644 --- a/rpcs3/rpcs3qt/settings_dialog.ui +++ b/rpcs3/rpcs3qt/settings_dialog.ui @@ -2379,13 +2379,6 @@ - - - - Accurate PPU Vector NaN Handling - - - @@ -4212,6 +4205,13 @@ + + + + Accurate PPU Vector NaN Handling + + + diff --git a/rpcs3/rpcs3qt/tooltips.h b/rpcs3/rpcs3qt/tooltips.h index d867b3220e..014c20b255 100644 --- a/rpcs3/rpcs3qt/tooltips.h +++ b/rpcs3/rpcs3qt/tooltips.h @@ -82,7 +82,6 @@ public: const QString fixup_ppunj = tr("Legacy option. Fixup result vector values in Non-Java Mode in PPU LLVM.\nIf unsure, do not modify this setting."); const QString accurate_dfma = tr("Use accurate double-precision FMA instructions in PPU and SPU backends.\nWhile disabling it might give a decent performance boost if your CPU doesn't support FMA, it may also introduce subtle bugs that otherwise do not occur.\nYou shouldn't disable it if your CPU supports FMA."); const QString fixup_ppuvnan = tr("Fixup NaN results in vector instructions in PPU backends.\nIf unsure, do not modify this setting."); - const QString accurate_ppuvnan = tr("Accurately set NaN results in vector instructions in PPU backends.\nIf unsure, do not modify this setting."); const QString accurate_ppufpcc = tr("Accurately set FPCC Bits in PPU backends.\nIf unsure, do not modify this setting."); const QString max_cpu_preempt = tr("Reduces CPU usage and power consumption, on mobile devices improves battery life. (0 means disabled)\nHigher values cause a more pronounced effect, but may cause audio or performance issues. A value of 50 or less is recommended.\nThis option forces an FPS limit because it's active when framerate is stable.\nThe lighter the game is on the hardware, the more power is saved by it. (until the preemption count barrier is reached)"); @@ -95,6 +94,7 @@ public: const QString accurate_getllar = tr("Accurately processes SPU MFC_GETLLAR operation."); const QString accurate_ppusat = tr("Accurately set Saturation Bit values in PPU backends.\nIf unsure, do not modify this setting."); const QString accurate_ppunj = tr("Respect Non-Java Mode Bit values for vector ops in PPU backends.\nIf unsure, do not modify this setting."); + const QString accurate_ppuvnan = tr("Accurately set NaN results in vector instructions in PPU backends.\nIf unsure, do not modify this setting."); const QString accurate_spu_dma = tr("Accurately processes SPU DMA operations."); const QString accurate_cache_line_stores = tr("Accurately processes PPU DCBZ instruction.\nIn addition, when combined with Accurate SPU DMA, SPU PUT cache line accesses will be processed atomically."); const QString accurate_rsx_access = tr("Forces RSX pauses on SPU MFC_GETLLAR and SPU MFC_PUTLLUC operations.");