From 2d82e3ef9adc110f357f6666c8bc4fce45c59649 Mon Sep 17 00:00:00 2001 From: Megamouse Date: Sat, 13 Jan 2024 15:34:32 +0100 Subject: [PATCH] Qt: use fs::get_temp_dir during updates GetTempPathW was falsely using size in bytes instead of string length. --- rpcs3/rpcs3qt/update_manager.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/rpcs3/rpcs3qt/update_manager.cpp b/rpcs3/rpcs3qt/update_manager.cpp index 7dc6c06732..c01dfe613d 100644 --- a/rpcs3/rpcs3qt/update_manager.cpp +++ b/rpcs3/rpcs3qt/update_manager.cpp @@ -396,12 +396,7 @@ bool update_manager::handle_rpcs3(const QByteArray& data, bool auto_accept) const std::string exe_dir = rpcs3::utils::get_exe_dir(); const std::string orig_path = exe_dir + "rpcs3.exe"; const std::wstring wchar_orig_path = utf8_to_wchar(orig_path); - - wchar_t wide_temp_path[MAX_PATH + 1]{}; - GetTempPathW(sizeof(wide_temp_path), wide_temp_path); - - std::string tmpfile_path = wchar_to_utf8(wide_temp_path); - tmpfile_path += "\\rpcs3_update.7z"; + const std::string tmpfile_path = fs::get_temp_dir() + "\\rpcs3_update.7z"; fs::file tmpfile(tmpfile_path, fs::read + fs::write + fs::create + fs::trunc); if (!tmpfile)