From 3a4e3fa53a1fc3b06a39b0f7ba38488f292e3539 Mon Sep 17 00:00:00 2001 From: kd-11 Date: Thu, 21 Mar 2019 12:48:00 +0300 Subject: [PATCH] rsx: Fix use-after-modify condition when inserting a draw command out of order - Fixes barrier->range rebase after the insert --- rpcs3/Emu/RSX/rsx_methods.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/rpcs3/Emu/RSX/rsx_methods.h b/rpcs3/Emu/RSX/rsx_methods.h index 96d62686c4..5450f2f68b 100644 --- a/rpcs3/Emu/RSX/rsx_methods.h +++ b/rpcs3/Emu/RSX/rsx_methods.h @@ -95,10 +95,7 @@ namespace rsx void insert_draw_command(u32 index, const draw_range_t& range) { auto range_It = draw_command_ranges.begin(); - while (index--) - { - ++range_It; - } + std::advance(range_It, index); draw_command_ranges.insert(range_It, range);