From 54bfe2e102f1ee1ee644c095c543d96014f8a28d Mon Sep 17 00:00:00 2001 From: Rui Pinheiro Date: Sun, 9 Dec 2018 23:38:00 +0000 Subject: [PATCH] Add log warning on slow flush path --- rpcs3/Emu/RSX/Common/texture_cache_utils.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/rpcs3/Emu/RSX/Common/texture_cache_utils.h b/rpcs3/Emu/RSX/Common/texture_cache_utils.h index 9ed28cf3e4..363ca365cc 100644 --- a/rpcs3/Emu/RSX/Common/texture_cache_utils.h +++ b/rpcs3/Emu/RSX/Common/texture_cache_utils.h @@ -1420,11 +1420,19 @@ namespace rsx } else { + ASSERT(valid_length % rsx_pitch == 0); u8 *_src = src; u32 _dst = dst; const auto num_rows = valid_length / rsx_pitch; + + const auto num_exclusions = flush_exclusions.size(); + if (num_exclusions > 0) + { + LOG_WARNING(RSX, "Slow imp_flush path triggered with non-empty flush_exclusions (%d exclusions, %d rows), performance might suffer", num_exclusions, num_rows); + } + for (u32 row = 0; row < num_rows; ++row) { imp_flush_memcpy(_dst, _src, real_pitch);