mirrors/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-04-20 03:25:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

vk: Only declare explicit subpass dependencies for RADV

Browse source
This commit is contained in:
kd-11 2020-02-16 17:15:44 +03:00 • committed by kd-11
parent a08ed0d22e
commit 5e6b1003ec
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
rpcs3/Emu/RSX/VK/VKRenderPass.cpp
View file

@ -218,8 +218,19 @@ namespace vk
rp_info.pAttachments = attachments.data();
rp_info.subpassCount = 1;
rp_info.pSubpasses = &subpass;
rp_info.dependencyCount = 2;
rp_info.pDependencies = null_subpass_dependencies;
if (vk::get_driver_vendor() == vk::driver_vendor::RADV)
{
// So, according to spec, if you do not explicitly define the relationship between a subpass and its neighbours,
// a full pipeline barrier will be inserted for you, which is awful for performance.
// However, only RADV seems to do this and it does not work for other vendors.
// NVIDIA specifically slows to a crawl even with a TOP_OF_PIPE->TOP_OF_PIPE dependency with no dependent access.
// RPCS3 does not actually want to declare any dependency here, we have explicit pipeline barriers for our tasks.
// Workaround: Only provide this null dep chain for RADV
rp_info.dependencyCount = 2;
rp_info.pDependencies = null_subpass_dependencies;
}
VkRenderPass result;
CHECK_RESULT(vkCreateRenderPass(dev, &rp_info, NULL, &result));