diff --git a/Utilities/Config.h b/Utilities/Config.h index f303fe54b7..24f910e555 100644 --- a/Utilities/Config.h +++ b/Utilities/Config.h @@ -543,7 +543,7 @@ namespace cfg std::string def; string(node* owner, std::string name, std::string def = {}, bool dynamic = false) - : _base(type::string, owner, name, dynamic) + : _base(type::string, owner, std::move(name), dynamic) , m_value(def) , def(std::move(def)) { diff --git a/rpcs3/Emu/RSX/GSFrameBase.h b/rpcs3/Emu/RSX/GSFrameBase.h index 1f426f9ef1..ef17378dd3 100644 --- a/rpcs3/Emu/RSX/GSFrameBase.h +++ b/rpcs3/Emu/RSX/GSFrameBase.h @@ -32,5 +32,5 @@ public: virtual bool can_consume_frame() const = 0; virtual void present_frame(std::vector& data, u32 pitch, u32 width, u32 height, bool is_bgra) const = 0; - virtual void take_screenshot(const std::vector sshot_data, u32 sshot_width, u32 sshot_height, bool is_bgra) = 0; + virtual void take_screenshot(std::vector&& sshot_data, u32 sshot_width, u32 sshot_height, bool is_bgra) = 0; }; diff --git a/rpcs3/Input/ps_move_config.h b/rpcs3/Input/ps_move_config.h index 0e12889956..3fbae71dab 100644 --- a/rpcs3/Input/ps_move_config.h +++ b/rpcs3/Input/ps_move_config.h @@ -7,7 +7,7 @@ struct cfg_ps_move final : cfg::node { cfg_ps_move() : cfg::node() {} - cfg_ps_move(cfg::node* owner, std::string name) : cfg::node(owner, name) {} + cfg_ps_move(cfg::node* owner, std::string name) : cfg::node(owner, std::move(name)) {} cfg::uint<0, 255> r{ this, "Color R", 0, true }; cfg::uint<0, 255> g{ this, "Color G", 0, true }; diff --git a/rpcs3/rpcs3qt/gs_frame.cpp b/rpcs3/rpcs3qt/gs_frame.cpp index b8371a19e4..7b5481d2d4 100644 --- a/rpcs3/rpcs3qt/gs_frame.cpp +++ b/rpcs3/rpcs3qt/gs_frame.cpp @@ -793,7 +793,7 @@ void gs_frame::present_frame(std::vector& data, u32 pitch, u32 width, u32 he video_provider.present_frame(data, pitch, width, height, is_bgra); } -void gs_frame::take_screenshot(std::vector data, u32 sshot_width, u32 sshot_height, bool is_bgra) +void gs_frame::take_screenshot(std::vector&& data, u32 sshot_width, u32 sshot_height, bool is_bgra) { std::thread( [sshot_width, sshot_height, is_bgra](std::vector sshot_data) diff --git a/rpcs3/rpcs3qt/gs_frame.h b/rpcs3/rpcs3qt/gs_frame.h index 8d6316bd88..38bbaa0a3e 100644 --- a/rpcs3/rpcs3qt/gs_frame.h +++ b/rpcs3/rpcs3qt/gs_frame.h @@ -79,7 +79,7 @@ public: bool can_consume_frame() const override; void present_frame(std::vector& data, u32 pitch, u32 width, u32 height, bool is_bgra) const override; - void take_screenshot(std::vector data, u32 sshot_width, u32 sshot_height, bool is_bgra) override; + void take_screenshot(std::vector&& data, u32 sshot_width, u32 sshot_height, bool is_bgra) override; protected: video_renderer m_renderer;