From 72cccb691c7bd32bdccea2617b703cb0ceb8d026 Mon Sep 17 00:00:00 2001 From: Megamouse Date: Sat, 10 Aug 2024 22:54:49 +0200 Subject: [PATCH] Qt/input: update buttons at 100 hz instead of 1000 hz. This reduces cpu usage without any noticeable drawback. --- rpcs3/rpcs3qt/pad_settings_dialog.cpp | 8 ++++---- rpcs3/rpcs3qt/pad_settings_dialog.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/rpcs3/rpcs3qt/pad_settings_dialog.cpp b/rpcs3/rpcs3qt/pad_settings_dialog.cpp index 3cf67dbbba..097bb7b001 100644 --- a/rpcs3/rpcs3qt/pad_settings_dialog.cpp +++ b/rpcs3/rpcs3qt/pad_settings_dialog.cpp @@ -560,7 +560,7 @@ void pad_settings_dialog::InitButtons() while (thread_ctrl::state() != thread_state::aborting) { - thread_ctrl::wait_for(1000); + thread_ctrl::wait_for(10000); if (m_input_thread_state != input_thread_state::active) { @@ -796,7 +796,7 @@ void pad_settings_dialog::ReactivateButtons() ui->chooseProduct->setFocusPolicy(Qt::WheelFocus); } -void pad_settings_dialog::RepaintPreviewLabel(QLabel* l, int deadzone, int anti_deadzone, int desired_width, int x, int y, int squircle, double multiplier) const +void pad_settings_dialog::RepaintPreviewLabel(QLabel* label, int deadzone, int anti_deadzone, int desired_width, int x, int y, int squircle, double multiplier) const { desired_width = 100; // Let's keep a fixed size for these labels for now const qreal deadzone_max = m_handler ? m_handler->thumb_max : 255; // 255 used as fallback. The deadzone circle shall be small. @@ -884,7 +884,7 @@ void pad_settings_dialog::RepaintPreviewLabel(QLabel* l, int deadzone, int anti_ painter.end(); - l->setPixmap(pixmap); + label->setPixmap(pixmap); } void pad_settings_dialog::keyPressEvent(QKeyEvent *keyEvent) @@ -1624,7 +1624,7 @@ void pad_settings_dialog::ChangeHandler() if (ui->chooseDevice->isEnabled() && ui->chooseDevice->currentIndex() >= 0) { start_input_thread(); - m_timer_input.start(1); + m_timer_input.start(10); m_timer_pad_refresh.start(1000); } } diff --git a/rpcs3/rpcs3qt/pad_settings_dialog.h b/rpcs3/rpcs3qt/pad_settings_dialog.h index c5fcc922a2..1e80ff65f7 100644 --- a/rpcs3/rpcs3qt/pad_settings_dialog.h +++ b/rpcs3/rpcs3qt/pad_settings_dialog.h @@ -207,7 +207,7 @@ private: void ReloadButtons(); /** Repaints a stick deadzone preview label */ - void RepaintPreviewLabel(QLabel* l, int deadzone, int anti_deadzone, int desired_width, int x, int y, int squircle, double multiplier) const; + void RepaintPreviewLabel(QLabel* label, int deadzone, int anti_deadzone, int desired_width, int x, int y, int squircle, double multiplier) const; QString GetLocalizedPadHandler(const QString& original, pad_handler handler); QString GetLocalizedPadName(pad_handler handler, const QString& original, usz index);