mirrors/rpcs3
0
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-08-02 22:30:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

rsx: Allow for proper data checks when WCB/WDB is enabled

Browse source
This commit is contained in:
kd-11 2020-02-03 19:06:25 +03:00 • committed by kd-11
commit b9ec012922
1 changed files with 11 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
rpcs3/Emu/RSX/Common/texture_cache.h
View file

@ -1666,13 +1666,18 @@ namespace rsx
if (const auto section_count = result.external_subresource_desc.sections_to_copy.size(); if (const auto section_count = result.external_subresource_desc.sections_to_copy.size();
section_count > 0) section_count > 0)
{ {
// TODO: Some games may render a small region (e.g 1024x256x2) and sample a huge texture (e.g 1024x1024). bool result_is_valid = result.atlas_covers_target_area(section_count == 1 ? 99 : 90);
// Seen in APF2k8 - this causes missing bits to be reuploaded from CPU which can cause WCB requirement. if (!result_is_valid && _pool == 0 && !g_cfg.video.write_color_buffers && !g_cfg.video.write_depth_buffer)
// Properly fix this by introducing partial data upload into the surface cache in such cases and making RCB/RDB {
// enabled by default. Blit engine already handles this correctly. // HACK: Avoid WCB requirement for some games with wrongly declared sampler dimensions.
// TODO: Some games may render a small region (e.g 1024x256x2) and sample a huge texture (e.g 1024x1024).
// Seen in APF2k8 - this causes missing bits to be reuploaded from CPU which can cause WCB requirement.
// Properly fix this by introducing partial data upload into the surface cache in such cases and making RCB/RDB
// enabled by default. Blit engine already handles this correctly.
result_is_valid = true;
}
if (_pool == 0 || /* Hack to avoid WCB requirement for some games with wrongly declared sampler dimensions */ if (result_is_valid)
result.atlas_covers_target_area(section_count == 1? 99 : 90))
{ {
// Optionally disallow caching if resource is being written to as it is being read from // Optionally disallow caching if resource is being written to as it is being read from
for (const auto& section : overlapping_fbos) for (const auto& section : overlapping_fbos)