mirrors/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-04-20 11:36:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

rsx/vp: Emit more efficient code

Browse source 
- Applies more aggressive DCE in the analyser. Dead-code in tails could happen before in some cases.
This commit is contained in:
kd-11 2023-11-09 02:07:25 +03:00 • committed by kd-11
parent 85cefec5a3
commit c41130080d
1 changed files with 22 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
rpcs3/Emu/RSX/Program/ProgramStateCache.cpp
View file

@ -50,7 +50,6 @@ vertex_program_utils::vertex_program_metadata vertex_program_utils::analyse_vert
{
u32 current_instruction = start;
std::set<u32> conditional_targets;
bool has_printed_error = false;
while (true)
{
@ -60,21 +59,13 @@ vertex_program_utils::vertex_program_metadata vertex_program_utils::analyse_vert
{
if (!fast_exit)
{
if (!has_printed_error)
{
// This can be harmless if a dangling RET was encountered before.
// This can also be legal in case of BRB...BRI loops since BRIs are conditional. Might just be a loop with exit cond.
rsx_log.warning("vp_analyser: Possible infinite loop detected");
has_printed_error = true;
}
current_instruction++;
continue;
}
else
{
// Block walk, looking for earliest exit
break;
// This can be harmless if a dangling RET was encountered before.
// This can also be legal in case of BRB...BRI loops since BRIs are conditional. Might just be a loop with exit cond.
rsx_log.warning("vp_analyser: Possible infinite loop detected");
}
// There is never any reason to continue scanning after self-intersecting on the control-flow tree.
break;
}
const auto instruction = v128::loadu(&data[current_instruction * 4]);
@ -212,9 +203,23 @@ vertex_program_utils::vertex_program_metadata vertex_program_utils::analyse_vert
}
}
if ((d3.end && (fast_exit || current_instruction >= instruction_range.second)) ||
(current_instruction + 1) == rsx::max_vertex_program_instructions)
// Check exit conditions...
if (d3.end)
{
// We have seen an end of instructions marker.
// Multiple exits may exist, usually skipped over by branching. Do not exit on end unless there is no branching.
if (!has_branch_instruction || fast_exit || current_instruction >= instruction_range.second)
{
// Conditions:
// 1. No branching so far. This will always be the exit.
// 2. Fast exit flag is set. This happens when walking through subroutines.
// 3. We've gone beyond the known instruction range. In this scenario, this is the furthest end marker seen so far. It has to be reached by some earlier branch.
break;
}
}
else if ((current_instruction + 1) == rsx::max_vertex_program_instructions)
{
// No more instructions to read.
break;
}