From df96be199b26d01ef13e88d45c75e83ec94e34e7 Mon Sep 17 00:00:00 2001 From: Ani Date: Sat, 25 Sep 2021 21:53:53 +0100 Subject: [PATCH] config: Remove Lower SPU Priority setting --- rpcs3/Emu/CPU/CPUThread.cpp | 5 ----- rpcs3/Emu/system_config.h | 1 - rpcs3/rpcs3qt/emu_settings_type.h | 2 -- rpcs3/rpcs3qt/settings_dialog.cpp | 3 --- rpcs3/rpcs3qt/settings_dialog.ui | 7 ------- rpcs3/rpcs3qt/tooltips.h | 1 - 6 files changed, 19 deletions(-) diff --git a/rpcs3/Emu/CPU/CPUThread.cpp b/rpcs3/Emu/CPU/CPUThread.cpp index 0ccc42a6e7..a7b5a3442f 100644 --- a/rpcs3/Emu/CPU/CPUThread.cpp +++ b/rpcs3/Emu/CPU/CPUThread.cpp @@ -411,11 +411,6 @@ void cpu_thread::operator()() } if (id_type() == 2) { - if (g_cfg.core.lower_spu_priority) - { - thread_ctrl::set_native_priority(-1); - } - // force input/output denormals to zero for SPU threads (FTZ/DAZ) _mm_setcsr( _mm_getcsr() | 0x8040 ); diff --git a/rpcs3/Emu/system_config.h b/rpcs3/Emu/system_config.h index 9bc1a51100..3a9cf2165a 100644 --- a/rpcs3/Emu/system_config.h +++ b/rpcs3/Emu/system_config.h @@ -31,7 +31,6 @@ struct cfg_root : cfg::node cfg::_enum thread_scheduler{this, "Thread Scheduler Mode", thread_scheduler_mode::os}; cfg::_bool set_daz_and_ftz{ this, "Set DAZ and FTZ", false }; cfg::_enum spu_decoder{ this, "SPU Decoder", spu_decoder_type::llvm }; - cfg::_bool lower_spu_priority{ this, "Lower SPU thread priority" }; cfg::_bool spu_getllar_polling_detection{ this, "SPU GETLLAR polling detection", false, true }; cfg::_bool spu_debug{ this, "SPU Debug" }; cfg::_bool mfc_debug{ this, "MFC Debug" }; diff --git a/rpcs3/rpcs3qt/emu_settings_type.h b/rpcs3/rpcs3qt/emu_settings_type.h index d032f3125d..652d68733a 100644 --- a/rpcs3/rpcs3qt/emu_settings_type.h +++ b/rpcs3/rpcs3qt/emu_settings_type.h @@ -12,7 +12,6 @@ enum class emu_settings_type SPUDecoder, HookStaticFuncs, ThreadSchedulerMode, - LowerSPUThreadPrio, SPULoopDetection, PreferredSPUThreads, PPUDebug, @@ -164,7 +163,6 @@ inline static const QMap settings_location = { emu_settings_type::SPUDecoder, { "Core", "SPU Decoder"}}, { emu_settings_type::HookStaticFuncs, { "Core", "Hook static functions"}}, { emu_settings_type::ThreadSchedulerMode, { "Core", "Thread Scheduler Mode"}}, - { emu_settings_type::LowerSPUThreadPrio, { "Core", "Lower SPU thread priority"}}, { emu_settings_type::SPULoopDetection, { "Core", "SPU loop detection"}}, { emu_settings_type::PreferredSPUThreads, { "Core", "Preferred SPU Threads"}}, { emu_settings_type::PPUDebug, { "Core", "PPU Debug"}}, diff --git a/rpcs3/rpcs3qt/settings_dialog.cpp b/rpcs3/rpcs3qt/settings_dialog.cpp index 0793b54818..b90a5dbc81 100644 --- a/rpcs3/rpcs3qt/settings_dialog.cpp +++ b/rpcs3/rpcs3qt/settings_dialog.cpp @@ -195,9 +195,6 @@ settings_dialog::settings_dialog(std::shared_ptr gui_settings, std // Checkboxes - m_emu_settings->EnhanceCheckBox(ui->lowerSPUThrPrio, emu_settings_type::LowerSPUThreadPrio); - SubscribeTooltip(ui->lowerSPUThrPrio, tooltips.settings.lower_spu_thread_priority); - m_emu_settings->EnhanceCheckBox(ui->spuLoopDetection, emu_settings_type::SPULoopDetection); SubscribeTooltip(ui->spuLoopDetection, tooltips.settings.spu_loop_detection); diff --git a/rpcs3/rpcs3qt/settings_dialog.ui b/rpcs3/rpcs3qt/settings_dialog.ui index 3d28285ea6..e897161b1b 100644 --- a/rpcs3/rpcs3qt/settings_dialog.ui +++ b/rpcs3/rpcs3qt/settings_dialog.ui @@ -143,13 +143,6 @@ Additional Settings - - - - Lower SPU thread priority - - - diff --git a/rpcs3/rpcs3qt/tooltips.h b/rpcs3/rpcs3qt/tooltips.h index 4838163813..63edfb074a 100644 --- a/rpcs3/rpcs3qt/tooltips.h +++ b/rpcs3/rpcs3qt/tooltips.h @@ -65,7 +65,6 @@ public: const QString spu_llvm = tr("Recompiles and caches the game's SPU code using the LLVM Recompiler before running which adds extra start-up time.\nThis is the fastest option with very good compatibility.\nIf you experience issues, use the ASMJIT Recompiler."); const QString accurate_xfloat = tr("Adds extra accuracy to SPU float vectors processing.\nFixes bugs in various games at the cost of performance.\nThis setting is only applied when SPU Decoder is set to Fast or LLVM."); const QString enable_thread_scheduler = tr("Control how RPCS3 utilizes the threads of your system.\nEach option heavily depends on the game and on your CPU. It's recommended to try each option to find out which performs the best.\nChanging the thread scheduler is not supported on CPUs with less than 12 threads."); - const QString lower_spu_thread_priority = tr("Runs SPU threads with lower priority than PPU threads.\nUsually faster on an i3 or i5, possibly slower or no difference on an i7 or Ryzen."); const QString spu_loop_detection = tr("Try to detect loop conditions in SPU kernels and use them as scheduling hints.\nImproves performance and reduces CPU usage.\nMay cause severe audio stuttering in rare cases."); const QString enable_tsx = tr("Enable usage of TSX instructions.\nNeeds to be forced on some Haswell or Broadwell CPUs.\nForcing this on older Hardware can lead to system instability, use it with caution."); const QString spu_block_size = tr("This option controls the SPU analyser, particularly the size of compiled units. The Mega and Giga modes may improve performance by tying smaller units together, decreasing the number of compiled units but increasing their size.\nUse the Safe mode for maximum compatibility.");