avoid access to temporary value

This commit is contained in:
digant73 2024-12-05 18:35:23 +01:00
commit fa40175644
2 changed files with 3 additions and 2 deletions

View file

@ -15,6 +15,7 @@ welcome_dialog::welcome_dialog(std::shared_ptr<gui_settings> gui_settings, bool
: QDialog(parent) : QDialog(parent)
, ui(new Ui::welcome_dialog) , ui(new Ui::welcome_dialog)
, m_gui_settings(std::move(gui_settings)) , m_gui_settings(std::move(gui_settings))
, m_use_dark_theme(gui::utils::dark_mode_active())
{ {
ui->setupUi(this); ui->setupUi(this);
@ -27,7 +28,7 @@ welcome_dialog::welcome_dialog(std::shared_ptr<gui_settings> gui_settings, bool
ui->do_not_show->setEnabled(!is_manual_show); ui->do_not_show->setEnabled(!is_manual_show);
ui->do_not_show->setChecked(!m_gui_settings->GetValue(gui::ib_show_welcome).toBool()); ui->do_not_show->setChecked(!m_gui_settings->GetValue(gui::ib_show_welcome).toBool());
ui->use_dark_theme->setEnabled(!is_manual_show); ui->use_dark_theme->setEnabled(!is_manual_show);
ui->use_dark_theme->setChecked(gui::utils::dark_mode_active()); ui->use_dark_theme->setChecked(m_use_dark_theme);
ui->icon_label->load(QStringLiteral(":/rpcs3.svg")); ui->icon_label->load(QStringLiteral(":/rpcs3.svg"));
ui->label_3->setText(tr( ui->label_3->setText(tr(
R"( R"(

View file

@ -24,5 +24,5 @@ public:
private: private:
std::unique_ptr<Ui::welcome_dialog> ui; std::unique_ptr<Ui::welcome_dialog> ui;
std::shared_ptr<gui_settings> m_gui_settings; std::shared_ptr<gui_settings> m_gui_settings;
bool m_use_dark_theme = false; bool m_use_dark_theme;
}; };