From 066d3dfbcbf87e97e4b25038891533bb283f983f Mon Sep 17 00:00:00 2001 From: yuchenlin Date: Sat, 8 Sep 2018 09:16:04 +0800 Subject: [PATCH 1/2] prevent closing console right after process error in windows Signed-off-by: yuchenlin --- app/src/main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/src/main.c b/app/src/main.c index 634c7bb4..1322dee2 100644 --- a/app/src/main.c +++ b/app/src/main.c @@ -319,5 +319,10 @@ int main(int argc, char *argv[]) { avformat_network_deinit(); // ignore failure +#if defined (__WINDOWS__) && ! defined (WINDOWS_NOCONSOLE) + if (res != 0) { + system("pause"); + } +#endif return res; } From 43e7af3d5bf711875def213e8374d245b1067795 Mon Sep 17 00:00:00 2001 From: yuchenlin Date: Sat, 8 Sep 2018 09:16:53 +0800 Subject: [PATCH 2/2] return PROCESS_ERROR_MISSING_BINARY in windows exec Signed-off-by: yuchenlin --- app/src/sys/win/command.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/src/sys/win/command.c b/app/src/sys/win/command.c index 7a29442d..adb6e0c3 100644 --- a/app/src/sys/win/command.c +++ b/app/src/sys/win/command.c @@ -29,7 +29,11 @@ enum process_result cmd_execute(const char *path, const char *const argv[], HAND #endif if (!CreateProcess(NULL, cmd, NULL, NULL, FALSE, flags, NULL, NULL, &si, &pi)) { *handle = NULL; - return PROCESS_ERROR_GENERIC; + if (GetLastError() == ERROR_FILE_NOT_FOUND) { + return PROCESS_ERROR_MISSING_BINARY; + } else { + return PROCESS_ERROR_GENERIC; + } } *handle = pi.hProcess;