Merge branch 'shadps4-emu:main' into doc-clang

.github/workflows/build.yml

@@ -402,6 +402,15 @@ jobs:
           fi
         done
   
+    - name: Get latest release information
+      id: get_latest_release
+      env:
+        GITHUB_TOKEN: ${{ secrets.SHADPS4_TOKEN_REPO }}
+      run: |
+        api_url="https://api.github.com/repos/${{ github.repository }}"
+        latest_release_info=$(curl -H "Authorization: token $GITHUB_TOKEN" "$api_url/releases/latest")
+        echo "last_release_tag=$(echo "$latest_release_info" | jq -r '.tag_name')" >> $GITHUB_ENV
+
     - name: Create Pre-Release on GitHub
       id: create_release
       uses: ncipollo/release-action@v1
@@ -411,8 +420,8 @@ jobs:
         tag: "Pre-release-shadPS4-${{ needs.get-info.outputs.date }}-${{ needs.get-info.outputs.shorthash }}"
         draft: false
         prerelease: true
-        artifacts: |
+        body: "Full Changelog: [${{ env.last_release_tag }}...${{ needs.get-info.outputs.shorthash }}](https://github.com/shadps4-emu/shadPS4/compare/${{ env.last_release_tag }}...${{ needs.get-info.outputs.shorthash }})"
-          ./artifacts/*.zip
+        artifacts: ./artifacts/*.zip
     
     - name: Get current pre-release information
       env:

CMakeSettings.json

@@ -9,7 +9,8 @@
       "cmakeCommandArgs": "",
       "buildCommandArgs": "",
       "ctestCommandArgs": "",
-      "inheritEnvironments": [ "clang_cl_x64_x64" ]
+      "inheritEnvironments": [ "clang_cl_x64_x64" ],
+      "intelliSenseMode": "windows-clang-x64"
     },
     {
       "name": "x64-Clang-Debug",
@@ -20,7 +21,8 @@
       "cmakeCommandArgs": "",
       "buildCommandArgs": "",
       "ctestCommandArgs": "",
-      "inheritEnvironments": [ "clang_cl_x64_x64" ]
+      "inheritEnvironments": [ "clang_cl_x64_x64" ],
+      "intelliSenseMode": "windows-clang-x64"
     },
     {
       "name": "x64-Clang-RelWithDebInfo",
@@ -31,7 +33,8 @@
       "cmakeCommandArgs": "",
       "buildCommandArgs": "",
       "ctestCommandArgs": "",
-      "inheritEnvironments": [ "clang_cl_x64_x64" ]
+      "inheritEnvironments": [ "clang_cl_x64_x64" ],
+      "intelliSenseMode": "windows-clang-x64"
     }
   ]
 }

src/core/address_space.cpp

@@ -72,7 +72,8 @@ struct AddressSpace::Impl {
             }
             reduction += ReductionOnFail;
         }
-        ASSERT_MSG(virtual_base, "Unable to reserve virtual address space!");
+        ASSERT_MSG(virtual_base, "Unable to reserve virtual address space: {}",
+                   Common::GetLastErrorMsg());
 
         // Take the reduction off of the system managed area, and leave the others unchanged.
         system_managed_base = virtual_base;

src/video_core/renderer_vulkan/liverpool_to_vk.cpp

@@ -381,12 +381,13 @@ static constexpr vk::FormatFeatureFlags2 GetNumberFormatFeatureFlags(
     case AmdGpu::NumberFormat::Uint:
     case AmdGpu::NumberFormat::Sint:
     case AmdGpu::NumberFormat::Float:
-        return BufferRead | BufferWrite | ImageRead | ImageWrite;
+        return BufferRead | BufferWrite | ImageRead | ImageWrite | Mrt;
     case AmdGpu::NumberFormat::Uscaled:
     case AmdGpu::NumberFormat::Sscaled:
     case AmdGpu::NumberFormat::SnormNz:
         return BufferRead | ImageRead;
     case AmdGpu::NumberFormat::Srgb:
+        return ImageRead | Mrt;
     case AmdGpu::NumberFormat::Ubnorm:
     case AmdGpu::NumberFormat::UbnromNz:
     case AmdGpu::NumberFormat::Ubint:

src/video_core/texture_cache/tile_manager.cpp

@@ -259,22 +259,6 @@ TileManager::TileManager(const Vulkan::Instance& instance, Vulkan::Scheduler& sc
         HostShaders::DETILE_M32X4_COMP,
     };
 
-    for (int pl_id = 0; pl_id < DetilerType::Max; ++pl_id) {
-        auto& ctx = detilers[pl_id];
-
-        const auto& module = Vulkan::Compile(
-            detiler_shaders[pl_id], vk::ShaderStageFlagBits::eCompute, instance.GetDevice());
-
-        // Set module debug name
-        auto module_name = magic_enum::enum_name(static_cast<DetilerType>(pl_id));
-        Vulkan::SetObjectName(instance.GetDevice(), module, module_name);
-
-        const vk::PipelineShaderStageCreateInfo shader_ci = {
-            .stage = vk::ShaderStageFlagBits::eCompute,
-            .module = module,
-            .pName = "main",
-        };
-
     boost::container::static_vector<vk::DescriptorSetLayoutBinding, 2> bindings{
         {
             .binding = 0,
@@ -295,10 +279,11 @@ TileManager::TileManager(const Vulkan::Instance& instance, Vulkan::Scheduler& sc
         .bindingCount = static_cast<u32>(bindings.size()),
         .pBindings = bindings.data(),
     };
-        auto [desc_layout_result, desc_layout] =
+    auto desc_layout_result = instance.GetDevice().createDescriptorSetLayoutUnique(desc_layout_ci);
-            instance.GetDevice().createDescriptorSetLayoutUnique(desc_layout_ci);
+    ASSERT_MSG(desc_layout_result.result == vk::Result::eSuccess,
-        ASSERT_MSG(desc_layout_result == vk::Result::eSuccess,
+               "Failed to create descriptor set layout: {}",
-                   "Failed to create descriptor set layout: {}", vk::to_string(desc_layout_result));
+               vk::to_string(desc_layout_result.result));
+    desc_layout = std::move(desc_layout_result.value);
 
     const vk::PushConstantRange push_constants = {
         .stageFlags = vk::ShaderStageFlagBits::eCompute,
@@ -306,6 +291,22 @@ TileManager::TileManager(const Vulkan::Instance& instance, Vulkan::Scheduler& sc
         .size = sizeof(DetilerParams),
     };
 
+    for (int pl_id = 0; pl_id < DetilerType::Max; ++pl_id) {
+        auto& ctx = detilers[pl_id];
+
+        const auto& module = Vulkan::Compile(
+            detiler_shaders[pl_id], vk::ShaderStageFlagBits::eCompute, instance.GetDevice());
+
+        // Set module debug name
+        auto module_name = magic_enum::enum_name(static_cast<DetilerType>(pl_id));
+        Vulkan::SetObjectName(instance.GetDevice(), module, module_name);
+
+        const vk::PipelineShaderStageCreateInfo shader_ci = {
+            .stage = vk::ShaderStageFlagBits::eCompute,
+            .module = module,
+            .pName = "main",
+        };
+
         const vk::DescriptorSetLayout set_layout = *desc_layout;
         const vk::PipelineLayoutCreateInfo layout_info = {
             .setLayoutCount = 1U,

src/video_core/texture_cache/tile_manager.h

@@ -51,6 +51,7 @@ private:
 private:
     const Vulkan::Instance& instance;
     Vulkan::Scheduler& scheduler;
+    vk::UniqueDescriptorSetLayout desc_layout;
     std::array<DetilerContext, DetilerType::Max> detilers;
 };