mirrors/shadPS4
0
0
Fork 0
mirror of https://github.com/shadps4-emu/shadPS4.git synced 2025-08-03 06:38:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

shader_recompiler: Don't bitcast on SetAttribute unless integer target.

Browse source
This commit is contained in:
squidbus 2024-09-30 04:35:00 -07:00
commit e7ffdaec2b
1 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp
View file

@ -85,11 +85,11 @@ Id OutputAttrPointer(EmitContext& ctx, IR::Attribute attr, u32 element) {
} }
} }
Id OutputAttrComponentType(EmitContext& ctx, IR::Attribute attr) { std::pair<Id, bool> OutputAttrComponentType(EmitContext& ctx, IR::Attribute attr) {
if (IR::IsParam(attr)) { if (IR::IsParam(attr)) {
const u32 index{u32(attr) - u32(IR::Attribute::Param0)}; const u32 index{u32(attr) - u32(IR::Attribute::Param0)};
const auto& info{ctx.output_params.at(index)}; const auto& info{ctx.output_params.at(index)};
return info.component_type; return {info.component_type, info.is_integer};
} }
switch (attr) { switch (attr) {
case IR::Attribute::Position0: case IR::Attribute::Position0:
@ -97,7 +97,7 @@ Id OutputAttrComponentType(EmitContext& ctx, IR::Attribute attr) {
case IR::Attribute::Position2: case IR::Attribute::Position2:
case IR::Attribute::Position3: case IR::Attribute::Position3:
case IR::Attribute::Depth: case IR::Attribute::Depth:
return ctx.F32[1]; return {ctx.F32[1], false};
case IR::Attribute::RenderTarget0: case IR::Attribute::RenderTarget0:
case IR::Attribute::RenderTarget1: case IR::Attribute::RenderTarget1:
case IR::Attribute::RenderTarget2: case IR::Attribute::RenderTarget2:
@ -108,7 +108,7 @@ Id OutputAttrComponentType(EmitContext& ctx, IR::Attribute attr) {
case IR::Attribute::RenderTarget7: { case IR::Attribute::RenderTarget7: {
const u32 index = u32(attr) - u32(IR::Attribute::RenderTarget0); const u32 index = u32(attr) - u32(IR::Attribute::RenderTarget0);
const auto& info{ctx.frag_outputs.at(index)}; const auto& info{ctx.frag_outputs.at(index)};
return info.component_type; return {info.component_type, info.is_integer};
} }
default: default:
throw NotImplementedException("Write attribute {}", attr); throw NotImplementedException("Write attribute {}", attr);
@ -257,8 +257,12 @@ void EmitSetAttribute(EmitContext& ctx, IR::Attribute attr, Id value, u32 elemen
return; return;
} }
const Id pointer{OutputAttrPointer(ctx, attr, element)}; const Id pointer{OutputAttrPointer(ctx, attr, element)};
const Id component_type{OutputAttrComponentType(ctx, attr)}; const auto component_type{OutputAttrComponentType(ctx, attr)};
ctx.OpStore(pointer, ctx.OpBitcast(component_type, value)); if (component_type.second) {
ctx.OpStore(pointer, ctx.OpBitcast(component_type.first, value));
} else {
ctx.OpStore(pointer, value);
}
} }
template <u32 N> template <u32 N>