From 30da7e61a4e8efad70876e734bf4e033203b6ed8 Mon Sep 17 00:00:00 2001 From: darktux Date: Fri, 5 Apr 2024 01:58:30 +0200 Subject: [PATCH] Fix NROs crashing and loading infinitely (#3) Commit from Suyu, looks like Yuzu devs forgot to initialize memory here. Comment from darktux: I've changed the use of memset to std::fill. Co-authored-by: Belal Ashraf Reviewed-on: http://y2nlvhmmk5jnsvechppxnbyzmmv3vbl7dvzn6ltwcdbpgxixp3clkgqd.onion/darktux/torzu/pulls/3 Co-authored-by: darktux Co-committed-by: darktux --- src/core/hle/service/am/process_creation.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/hle/service/am/process_creation.cpp b/src/core/hle/service/am/process_creation.cpp index 237151d061..81a8fb0b44 100644 --- a/src/core/hle/service/am/process_creation.cpp +++ b/src/core/hle/service/am/process_creation.cpp @@ -106,6 +106,7 @@ std::unique_ptr CreateApplicationProcess(std::vector& out_control, out_control = nacp.GetRawBytes(); } else { out_control.resize(sizeof(FileSys::RawNACP)); + std::fill(out_control.begin(), out_control.end(), 0); } auto& storage = system.GetContentProviderUnion();