mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-23 17:58:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/HTML: Update spec comments for "URL and history update steps"

Browse source 
Corresponds to:
https://github.com/whatwg/html/pull/10587
This commit is contained in:
Sam Atkins 2024-10-31 11:51:18 +00:00 • committed by Andreas Kling
commit 0a578ee345
Notes: github-actions[bot] 2024-11-09 14:28:45 +00:00
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/HTML/Navigable.cpp
View file

@ -1933,7 +1933,6 @@ void perform_url_and_history_update_steps(DOM::Document& document, URL::URL new_
// 2. Let activeEntry be navigable's active session history entry. // 2. Let activeEntry be navigable's active session history entry.
auto active_entry = navigable->active_session_history_entry(); auto active_entry = navigable->active_session_history_entry();
// FIXME: Spec should be updated to say "classic history api state" instead of serialized state
// 3. Let newEntry be a new session history entry, with // 3. Let newEntry be a new session history entry, with
// URL: newURL // URL: newURL
// serialized state: if serializedData is not null, serializedData; otherwise activeEntry's classic history API state // serialized state: if serializedData is not null, serializedData; otherwise activeEntry's classic history API state
@ -1988,6 +1987,8 @@ void perform_url_and_history_update_steps(DOM::Document& document, URL::URL new_
traversable->append_session_history_synchronous_navigation_steps(*navigable, JS::create_heap_function(document.realm().heap(), [traversable, navigable, new_entry, entry_to_replace, history_handling] { traversable->append_session_history_synchronous_navigation_steps(*navigable, JS::create_heap_function(document.realm().heap(), [traversable, navigable, new_entry, entry_to_replace, history_handling] {
// 1. Finalize a same-document navigation given traversable, navigable, newEntry, and entryToReplace. // 1. Finalize a same-document navigation given traversable, navigable, newEntry, and entryToReplace.
finalize_a_same_document_navigation(*traversable, *navigable, new_entry, entry_to_replace, history_handling); finalize_a_same_document_navigation(*traversable, *navigable, new_entry, entry_to_replace, history_handling);
// 2. FIXME: Invoke WebDriver BiDi history updated with navigable.
})); }));
} }