mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-12 19:19:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Put setting object's promise's in WindowOrWorkerGlobalScope

Browse source 
This aligns with an update to the HTML specification which instead
stores these promises on the global object instead of the settings
object.

It also makes progress towards implementing the ShadowRealm proposal
as these promises are not present in the 'synthetic' realm for that
proposal.
This commit is contained in:
Shannon Booth 2024-10-23 18:59:19 +13:00 • committed by Andrew Kaster
commit 1096b64936
Notes: github-actions[bot] 2024-10-23 17:30:50 +00:00
6 changed files with 129 additions and 119 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibWeb/HTML/WindowOrWorkerGlobalScope.h
View file

@ -80,6 +80,18 @@ public:
[[nodiscard]] JS::NonnullGCPtr<Crypto::Crypto> crypto();
void push_onto_outstanding_rejected_promises_weak_set(JS::Promise*);
// Returns true if removed, false otherwise.
bool remove_from_outstanding_rejected_promises_weak_set(JS::Promise*);
void push_onto_about_to_be_notified_rejected_promises_list(JS::NonnullGCPtr<JS::Promise>);
// Returns true if removed, false otherwise.
bool remove_from_about_to_be_notified_rejected_promises_list(JS::NonnullGCPtr<JS::Promise>);
void notify_about_rejected_promises(Badge<EventLoop>);
protected:
void initialize(JS::Realm&);
void visit_edges(JS::Cell::Visitor&);
@ -122,6 +134,13 @@ private:
JS::GCPtr<Crypto::Crypto> m_crypto;
bool m_error_reporting_mode { false };
// https://html.spec.whatwg.org/multipage/webappapis.html#about-to-be-notified-rejected-promises-list
Vector<JS::Handle<JS::Promise>> m_about_to_be_notified_rejected_promises_list;
// https://html.spec.whatwg.org/multipage/webappapis.html#outstanding-rejected-promises-weak-set
// The outstanding rejected promises weak set must not create strong references to any of its members, and implementations are free to limit its size, e.g. by removing old entries from it when new ones are added.
Vector<JS::GCPtr<JS::Promise>> m_outstanding_rejected_promises_weak_set;
};
}