mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibDebug: Make LineProgram::create take DwarfInfo as a const reference

Browse source 
The m_dwarf_info is never mutated, so it can be const.
This commit is contained in:
Sönke Holz 2024-05-04 13:00:35 +02:00 • committed by Andrew Kaster
commit 14ae04075e
Notes: sideshowbarker 2024-07-17 03:45:48 +09:00
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibDebug/Dwarf/LineProgram.cpp
View file

@ -13,13 +13,13 @@
namespace Debug::Dwarf { namespace Debug::Dwarf {
LineProgram::LineProgram(DwarfInfo& dwarf_info, size_t unit_offset) LineProgram::LineProgram(DwarfInfo const& dwarf_info, size_t unit_offset)
: m_dwarf_info(dwarf_info) : m_dwarf_info(dwarf_info)
, m_unit_offset(unit_offset) , m_unit_offset(unit_offset)
{ {
} }
ErrorOr<NonnullOwnPtr<LineProgram>> LineProgram::create(DwarfInfo& dwarf_info, SeekableStream& stream) ErrorOr<NonnullOwnPtr<LineProgram>> LineProgram::create(DwarfInfo const& dwarf_info, SeekableStream& stream)
{ {
auto offset = TRY(stream.tell()); auto offset = TRY(stream.tell());
auto program = TRY(adopt_nonnull_own_or_enomem(new (nothrow) LineProgram(dwarf_info, offset))); auto program = TRY(adopt_nonnull_own_or_enomem(new (nothrow) LineProgram(dwarf_info, offset)));

6
Userland/Libraries/LibDebug/Dwarf/LineProgram.h
View file

@ -109,7 +109,7 @@ class LineProgram {
AK_MAKE_NONMOVABLE(LineProgram); AK_MAKE_NONMOVABLE(LineProgram);
public: public:
static ErrorOr<NonnullOwnPtr<LineProgram>> create(DwarfInfo& dwarf_info, SeekableStream& stream); static ErrorOr<NonnullOwnPtr<LineProgram>> create(DwarfInfo const& dwarf_info, SeekableStream& stream);
struct LineInfo { struct LineInfo {
FlatPtr address { 0 }; FlatPtr address { 0 };
@ -134,7 +134,7 @@ public:
bool looks_like_embedded_resource() const; bool looks_like_embedded_resource() const;
private: private:
LineProgram(DwarfInfo& dwarf_info, size_t unit_offset); LineProgram(DwarfInfo const& dwarf_info, size_t unit_offset);
ErrorOr<void> parse_unit_header(SeekableStream& stream); ErrorOr<void> parse_unit_header(SeekableStream& stream);
ErrorOr<void> parse_source_directories(SeekableStream& stream); ErrorOr<void> parse_source_directories(SeekableStream& stream);
@ -175,7 +175,7 @@ private:
static constexpr u16 MIN_DWARF_VERSION = 3; static constexpr u16 MIN_DWARF_VERSION = 3;
static constexpr u16 MAX_DWARF_VERSION = 5; static constexpr u16 MAX_DWARF_VERSION = 5;
DwarfInfo& m_dwarf_info; DwarfInfo const& m_dwarf_info;
size_t m_unit_offset { 0 }; size_t m_unit_offset { 0 };
LineProgramUnitHeader32 m_unit_header {}; LineProgramUnitHeader32 m_unit_header {};