mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-30 04:39:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't trigger onchange event when setting <select> value

Browse source
This commit is contained in:
Arhcout 2024-09-25 10:56:02 +02:00 • committed by Andreas Kling
commit 5d00211a86
Notes: github-actions[bot] 2024-10-08 17:04:48 +00:00
3 changed files with 27 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/HTML/HTMLSelectElement-value-change-trigger-onchange.txt Normal file
View file

@ -0,0 +1 @@
PASS

26
Tests/LibWeb/Text/input/HTML/HTMLSelectElement-value-change-trigger-onchange.html Normal file
View file

@ -0,0 +1,26 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<select id="select-test">
<option value="A"></option>
<option value="B"></option>
</select>
<script>
asyncTest(done => {
const selectElement = document.getElementById("select-test");
let onchangeTriggered = false;
selectElement.onchange = () => {
onchangeTriggered = true;
}
selectElement.value = "B";
setTimeout(() => {
if (!onchangeTriggered) {
println("PASS");
} else {
println("FAILED");
}
done();
}, 1);
});
</script>

1
Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
View file

@ -295,7 +295,6 @@ WebIDL::ExceptionOr<void> HTMLSelectElement::set_value(String const& value)
for (auto const& option_element : list_of_options()) for (auto const& option_element : list_of_options())
option_element->set_selected(option_element->value() == value); option_element->set_selected(option_element->value() == value);
update_inner_text_element(); update_inner_text_element();
queue_input_and_change_events();
return {}; return {};
} }