mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-04 08:01:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibURL: Remove uneeded FIXME for UTF-8 decode in URL parsing

Browse source 
I believe this is in the specification since the spec technically
requires passing through a valid unicode string. However, our
implementation already handles a non valid unicode string, and will
do the replacement character substitution.
This commit is contained in:
Shannon Booth 2025-06-26 14:23:00 +12:00 • committed by Shannon Booth
parent 1f4bbc2bfb
commit 68b57daf84
Notes: github-actions[bot] 2025-06-27 06:47:02 +00:00
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibURL/Parser.cpp
View file

@ -575,7 +575,8 @@ Optional<Host> Parser::parse_host(StringView input, bool is_opaque)
// 3. Assert: input is not the empty string.
VERIFY(!input.is_empty());
// FIXME: 4. Let domain be the result of running UTF-8 decode without BOM on the percent-decoding of input.
// 4. Let domain be the result of running UTF-8 decode without BOM on the percent-decoding of input.
// NOTE: We do not need to do the UTF-8 decode without BOM as replacement is handled within domain_to_ascii.
auto domain = percent_decode(input);
// 5. Let asciiDomain be the result of running domain to ASCII with domain and false.