mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-29 12:19:54 +00:00
LibWeb+LibGfx: Paint dash array and offset for SVG and Canvas
This commit is contained in:
parent
a64902ba25
commit
6ba60188b4
Notes:
github-actions[bot]
2025-04-14 17:01:40 +00:00
Author: https://github.com/mehrankamal
Commit: 6ba60188b4
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4349
Reviewed-by: https://github.com/AtkinsSJ ✅
7 changed files with 16 additions and 7 deletions
|
@ -329,10 +329,16 @@ void CanvasRenderingContext2D::stroke_internal(Gfx::Path const& path)
|
|||
|
||||
auto& state = drawing_state();
|
||||
|
||||
// FIXME: Honor state's dash_list, and line_dash_offset.
|
||||
auto line_cap = to_gfx_cap(state.line_cap);
|
||||
auto line_join = to_gfx_join(state.line_join);
|
||||
painter->stroke_path(path, state.stroke_style.to_gfx_paint_style(), state.filters, state.line_width, state.global_alpha, state.current_compositing_and_blending_operator, line_cap, line_join, state.miter_limit);
|
||||
// FIXME: Need a Vector<float> for rendering dash_array, but state.dash_list is Vector<double>.
|
||||
// Maybe possible to avoid creating copies?
|
||||
auto dash_array = Vector<float> {};
|
||||
dash_array.ensure_capacity(state.dash_list.size());
|
||||
for (auto const& dash : state.dash_list) {
|
||||
dash_array.append(static_cast<float>(dash));
|
||||
}
|
||||
painter->stroke_path(path, state.stroke_style.to_gfx_paint_style(), state.filters, state.line_width, state.global_alpha, state.current_compositing_and_blending_operator, line_cap, line_join, state.miter_limit, dash_array, state.line_dash_offset);
|
||||
|
||||
did_draw(path.bounding_box());
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue