LibWeb: Log when document.execCommand and family are called

These are used by WPT. Log the commands so we know what we need to
implement.
This commit is contained in:
Timothy Flynn 2024-09-25 11:32:58 -04:00 committed by Tim Flynn
commit 96fbb33b13
Notes: github-actions[bot] 2024-09-25 18:04:40 +00:00
2 changed files with 18 additions and 12 deletions

View file

@ -4959,38 +4959,44 @@ JS::Value Document::named_item_value(FlyString const& name) const
} }
// https://w3c.github.io/editing/docs/execCommand/#execcommand() // https://w3c.github.io/editing/docs/execCommand/#execcommand()
bool Document::exec_command(String, bool, String) bool Document::exec_command(String const& command, bool show_ui, String const& value)
{ {
dbgln("FIXME: document.execCommand(\"{}\", {}, \"{}\")", command, show_ui, value);
return false; return false;
} }
// https://w3c.github.io/editing/docs/execCommand/#querycommandenabled() // https://w3c.github.io/editing/docs/execCommand/#querycommandenabled()
bool Document::query_command_enabled(String) bool Document::query_command_enabled(String const& command)
{ {
dbgln("FIXME: document.queryCommandEnabled(\"{}\")", command);
return false; return false;
} }
// https://w3c.github.io/editing/docs/execCommand/#querycommandindeterm() // https://w3c.github.io/editing/docs/execCommand/#querycommandindeterm()
bool Document::query_command_indeterm(String) bool Document::query_command_indeterm(String const& command)
{ {
dbgln("FIXME: document.queryCommandIndeterm(\"{}\")", command);
return false; return false;
} }
// https://w3c.github.io/editing/docs/execCommand/#querycommandstate() // https://w3c.github.io/editing/docs/execCommand/#querycommandstate()
bool Document::query_command_state(String) bool Document::query_command_state(String const& command)
{ {
dbgln("FIXME: document.queryCommandState(\"{}\")", command);
return false; return false;
} }
// https://w3c.github.io/editing/docs/execCommand/#querycommandsupported() // https://w3c.github.io/editing/docs/execCommand/#querycommandsupported()
bool Document::query_command_supported(String) bool Document::query_command_supported(String const& command)
{ {
dbgln("FIXME: document.queryCommandSupported(\"{}\")", command);
return false; return false;
} }
// https://w3c.github.io/editing/docs/execCommand/#querycommandvalue() // https://w3c.github.io/editing/docs/execCommand/#querycommandvalue()
String Document::query_command_value(String) String Document::query_command_value(String const& command)
{ {
dbgln("FIXME: document.queryCommandValue(\"{}\")", command);
return String {}; return String {};
} }

View file

@ -561,12 +561,12 @@ public:
void set_previous_document_unload_timing(DocumentUnloadTimingInfo const& previous_document_unload_timing) { m_previous_document_unload_timing = previous_document_unload_timing; } void set_previous_document_unload_timing(DocumentUnloadTimingInfo const& previous_document_unload_timing) { m_previous_document_unload_timing = previous_document_unload_timing; }
// https://w3c.github.io/editing/docs/execCommand/ // https://w3c.github.io/editing/docs/execCommand/
bool exec_command(String command_id, bool show_ui, String value); bool exec_command(String const& command, bool show_ui, String const& value);
bool query_command_enabled(String command_id); bool query_command_enabled(String const& command);
bool query_command_indeterm(String command_id); bool query_command_indeterm(String const& command);
bool query_command_state(String command_id); bool query_command_state(String const& command);
bool query_command_supported(String command_id); bool query_command_supported(String const& command);
String query_command_value(String command_id); String query_command_value(String const& command);
bool is_allowed_to_use_feature(PolicyControlledFeature) const; bool is_allowed_to_use_feature(PolicyControlledFeature) const;