mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-20 09:11:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

LibJS: Remove errant invocation to FormatNumericUnits

Browse source 
This is an editorial change in the Intl.DurationFormat proposal. See:
cdef892
This commit is contained in:
Timothy Flynn 2025-02-06 09:55:30 -05:00 • committed by Tim Flynn
parent ee649fc13b
commit 97f7cb805f
Notes: github-actions[bot] 2025-02-06 15:47:01 +00:00
1 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibJS/Runtime/Intl/DurationFormat.cpp
View file

@ -923,18 +923,14 @@ Vector<DurationFormatPart> partition_duration_format_pattern(VM& vm, DurationFor
// e. If style is "numeric" or "2-digit", then
if (style == DurationFormat::ValueStyle::Numeric || style == DurationFormat::ValueStyle::TwoDigit) {
// i. Append FormatNumericUnits(durationFormat, duration, unit, signDisplayed) to result.
// FIXME: Spec issue: This step should have been removed. See:
// https://github.com/tc39/proposal-intl-duration-format/issues/225
// ii. Let numericPartsList be FormatNumericUnits(durationFormat, duration, unit, signDisplayed).
// i. Let numericPartsList be FormatNumericUnits(durationFormat, duration, unit, signDisplayed).
auto numeric_parts_list = format_numeric_units(vm, duration_format, duration, unit, sign_displayed);
// iii. If numericPartsList is not empty, append numericPartsList to result.
// ii. If numericPartsList is not empty, append numericPartsList to result.
if (!numeric_parts_list.is_empty())
result.append(move(numeric_parts_list));
// iv. Set numericUnitFound to true.
// iii. Set numericUnitFound to true.
numeric_unit_found = true;
}
// f. Else,