mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-11 02:29:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibJS+LibWeb: Use realm.create<T> instead of heap.allocate<T>

Browse source 
The main motivation behind this is to remove JS specifics of the Realm
from the implementation of the Heap.

As a side effect of this change, this is a bit nicer to read than the
previous approach, and in my opinion, also makes it a little more clear
that this method is specific to a JavaScript Realm.
This commit is contained in:
Shannon Booth 2024-11-14 05:50:17 +13:00 • committed by Tim Flynn
commit 9b79a686eb
Notes: github-actions[bot] 2024-11-13 21:52:48 +00:00
326 changed files with 697 additions and 714 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/IndexedDB/IDBDatabase.cpp
View file

@ -26,7 +26,7 @@ IDBDatabase::~IDBDatabase() = default;
JS::NonnullGCPtr<IDBDatabase> IDBDatabase::create(JS::Realm& realm, Database& db)
{
return realm.heap().allocate<IDBDatabase>(realm, realm, db);
return realm.create<IDBDatabase>(realm, db);
}
void IDBDatabase::initialize(JS::Realm& realm)

2
Libraries/LibWeb/IndexedDB/IDBOpenDBRequest.cpp
View file

@ -29,7 +29,7 @@ void IDBOpenDBRequest::initialize(JS::Realm& realm)
JS::NonnullGCPtr<IDBOpenDBRequest> IDBOpenDBRequest::create(JS::Realm& realm)
{
return realm.heap().allocate<IDBOpenDBRequest>(realm, realm);
return realm.create<IDBOpenDBRequest>(realm);
}
// https://w3c.github.io/IndexedDB/#dom-idbopendbrequest-onblocked

2
Libraries/LibWeb/IndexedDB/IDBVersionChangeEvent.cpp
View file

@ -15,7 +15,7 @@ JS_DEFINE_ALLOCATOR(IDBVersionChangeEvent);
JS::NonnullGCPtr<IDBVersionChangeEvent> IDBVersionChangeEvent::create(JS::Realm& realm, FlyString const& event_name, IDBVersionChangeEventInit const& event_init)
{
return realm.heap().allocate<IDBVersionChangeEvent>(realm, realm, event_name, event_init);
return realm.create<IDBVersionChangeEvent>(realm, event_name, event_init);
}
IDBVersionChangeEvent::IDBVersionChangeEvent(JS::Realm& realm, FlyString const& event_name, IDBVersionChangeEventInit const& event_init)

2
Libraries/LibWeb/IndexedDB/Internal/Database.cpp
View file

@ -18,7 +18,7 @@ Database::~Database() = default;
JS::NonnullGCPtr<Database> Database::create(JS::Realm& realm, String const& name)
{
return realm.heap().allocate<Database>(realm, realm, name);
return realm.create<Database>(realm, name);
}
void Database::visit_edges(Visitor& visitor)