LibWeb: Fix goofy layout tree dumps for NavigableContainerViewport

We were neglecting to emit a newline before recursing into these.
This commit is contained in:
Andreas Kling 2025-02-22 14:51:34 +01:00 committed by Andreas Kling
commit a2fa3cbd69
Notes: github-actions[bot] 2025-02-22 19:03:40 +00:00
2 changed files with 21 additions and 10 deletions

View file

@ -334,6 +334,7 @@ void dump_tree(StringBuilder& builder, Layout::Node const& layout_node, bool sho
auto const& frame_box = static_cast<Layout::NavigableContainerViewport const&>(box);
if (auto const* document = frame_box.dom_node().content_document_without_origin_check()) {
builder.appendff(" (url: {})", document->url());
builder.append("\n"sv);
if (auto const* nested_layout_root = document->layout_node()) {
++indent;
dump_tree(builder, *nested_layout_root, show_box_model, show_cascaded_properties, interactive);

View file

@ -13,43 +13,53 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
frag 7 from NavigableContainerViewport start: 0, length: 0, rect: [18,228 10x10] baseline: 30
frag 8 from NavigableContainerViewport start: 0, length: 0, rect: [18,258 10x10] baseline: 30
frag 9 from NavigableContainerViewport start: 0, length: 0, rect: [18,288 10x10] baseline: 30
NavigableContainerViewport <iframe> at (18,18) content-size 10x10 children: not-inline (url: about:blank) Viewport <#document> at (0,0) content-size 10x10 children: not-inline
NavigableContainerViewport <iframe> at (18,18) content-size 10x10 children: not-inline (url: about:blank)
Viewport <#document> at (0,0) content-size 10x10 children: not-inline
BlockContainer <html> at (0,0) content-size 10x16 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 0x0 children: not-inline
NavigableContainerViewport <iframe> at (18,48) content-size 10x10 children: not-inline (url: about:blank) Viewport <#document> at (0,0) content-size 10x10 children: not-inline
NavigableContainerViewport <iframe> at (18,48) content-size 10x10 children: not-inline (url: about:blank)
Viewport <#document> at (0,0) content-size 10x10 children: not-inline
BlockContainer <html> at (0,0) content-size 10x16 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 0x0 children: not-inline
NavigableContainerViewport <iframe> at (18,78) content-size 10x10 children: not-inline (url: about:blank) Viewport <#document> at (0,0) content-size 10x10 children: not-inline
NavigableContainerViewport <iframe> at (18,78) content-size 10x10 children: not-inline (url: about:blank)
Viewport <#document> at (0,0) content-size 10x10 children: not-inline
BlockContainer <html> at (0,0) content-size 10x16 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 0x0 children: not-inline
NavigableContainerViewport <iframe> at (18,108) content-size 10x10 children: not-inline (url: about:blank) Viewport <#document> at (0,0) content-size 10x10 children: not-inline
NavigableContainerViewport <iframe> at (18,108) content-size 10x10 children: not-inline (url: about:blank)
Viewport <#document> at (0,0) content-size 10x10 children: not-inline
BlockContainer <html> at (0,0) content-size 10x16 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 0x0 children: not-inline
NavigableContainerViewport <iframe> at (18,138) content-size 10x10 children: not-inline (url: about:blank) Viewport <#document> at (0,0) content-size 10x10 children: not-inline
NavigableContainerViewport <iframe> at (18,138) content-size 10x10 children: not-inline (url: about:blank)
Viewport <#document> at (0,0) content-size 10x10 children: not-inline
BlockContainer <html> at (0,0) content-size 10x16 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 0x0 children: not-inline
NavigableContainerViewport <iframe> at (18,168) content-size 10x10 children: not-inline (url: about:blank) Viewport <#document> at (0,0) content-size 10x10 children: not-inline
NavigableContainerViewport <iframe> at (18,168) content-size 10x10 children: not-inline (url: about:blank)
Viewport <#document> at (0,0) content-size 10x10 children: not-inline
BlockContainer <html> at (0,0) content-size 10x16 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 0x0 children: not-inline
NavigableContainerViewport <iframe> at (18,198) content-size 10x10 children: not-inline (url: about:blank) Viewport <#document> at (0,0) content-size 10x10 children: not-inline
NavigableContainerViewport <iframe> at (18,198) content-size 10x10 children: not-inline (url: about:blank)
Viewport <#document> at (0,0) content-size 10x10 children: not-inline
BlockContainer <html> at (0,0) content-size 10x16 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 0x0 children: not-inline
NavigableContainerViewport <iframe> at (18,228) content-size 10x10 children: not-inline (url: about:blank) Viewport <#document> at (0,0) content-size 10x10 children: not-inline
NavigableContainerViewport <iframe> at (18,228) content-size 10x10 children: not-inline (url: about:blank)
Viewport <#document> at (0,0) content-size 10x10 children: not-inline
BlockContainer <html> at (0,0) content-size 10x16 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 0x0 children: not-inline
NavigableContainerViewport <iframe> at (18,258) content-size 10x10 children: not-inline (url: about:blank) Viewport <#document> at (0,0) content-size 10x10 children: not-inline
NavigableContainerViewport <iframe> at (18,258) content-size 10x10 children: not-inline (url: about:blank)
Viewport <#document> at (0,0) content-size 10x10 children: not-inline
BlockContainer <html> at (0,0) content-size 10x16 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 0x0 children: not-inline
NavigableContainerViewport <iframe> at (18,288) content-size 10x10 children: not-inline (url: about:blank) Viewport <#document> at (0,0) content-size 10x10 children: not-inline
NavigableContainerViewport <iframe> at (18,288) content-size 10x10 children: not-inline (url: about:blank)
Viewport <#document> at (0,0) content-size 10x10 children: not-inline
BlockContainer <html> at (0,0) content-size 10x16 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 0x0 children: not-inline