mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-25 19:56:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Tests: Use FileSystem::real_path when comparing paths

Browse source 
Paths in `headless-browser` tests were being compared by string value.
With this patch, they will be compared by their real path instead,
ensuring relative paths and symlinks are handled correctly.
This commit is contained in:
Jonne Ransijn 2024-11-07 21:57:10 +01:00 • committed by Tim Flynn
commit b625a92a0b
Notes: github-actions[bot] 2024-11-07 21:52:28 +00:00
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Ladybird/Headless/Test.cpp
View file

@ -48,7 +48,7 @@ static ErrorOr<void> load_test_config(StringView test_root_path)
for (auto const& group : config->groups()) { for (auto const& group : config->groups()) {
if (group == "Skipped"sv) { if (group == "Skipped"sv) {
for (auto& key : config->keys(group)) for (auto& key : config->keys(group))
s_skipped_tests.append(LexicalPath::join(test_root_path, key).string()); s_skipped_tests.append(TRY(FileSystem::real_path(LexicalPath::join(test_root_path, key).string())));
} else { } else {
warnln("Unknown group '{}' in config {}", group, config_path); warnln("Unknown group '{}' in config {}", group, config_path);
} }