mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/DOM: Stop moving is_value in create_element()

Browse source 
Clangd points out that 1) `set_is_value()` takes a reference so moving
isn't useful, and 2) we're reading `is_value` in step 3 after moving
it.
This commit is contained in:
Sam Atkins 2025-02-13 12:55:12 +00:00 • committed by Tim Ledbetter
commit c4889f3c5c
Notes: github-actions[bot] 2025-02-20 21:56:45 +00:00
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/DOM/ElementFactory.cpp
View file

@ -656,7 +656,7 @@ WebIDL::ExceptionOr<GC::Ref<Element>> create_element(Document& document, FlyStri
if (namespace_ == Namespace::HTML) { if (namespace_ == Namespace::HTML) {
auto element = create_html_element(realm, document, move(qualified_name)); auto element = create_html_element(realm, document, move(qualified_name));
element->set_is_value(move(is_value)); element->set_is_value(is_value);
element->set_custom_element_state(CustomElementState::Uncustomized); element->set_custom_element_state(CustomElementState::Uncustomized);
// 3. If namespace is the HTML namespace, and either localName is a valid custom element name or is is non-null, // 3. If namespace is the HTML namespace, and either localName is a valid custom element name or is is non-null,
@ -669,14 +669,14 @@ WebIDL::ExceptionOr<GC::Ref<Element>> create_element(Document& document, FlyStri
if (namespace_ == Namespace::SVG) { if (namespace_ == Namespace::SVG) {
auto element = create_svg_element(realm, document, qualified_name); auto element = create_svg_element(realm, document, qualified_name);
element->set_is_value(move(is_value)); element->set_is_value(is_value);
element->set_custom_element_state(CustomElementState::Uncustomized); element->set_custom_element_state(CustomElementState::Uncustomized);
return element; return element;
} }
if (namespace_ == Namespace::MathML) { if (namespace_ == Namespace::MathML) {
auto element = create_mathml_element(realm, document, qualified_name); auto element = create_mathml_element(realm, document, qualified_name);
element->set_is_value(move(is_value)); element->set_is_value(is_value);
element->set_custom_element_state(CustomElementState::Uncustomized); element->set_custom_element_state(CustomElementState::Uncustomized);
return element; return element;
} }