LibWeb/WebGL: Implement createRenderbuffer

Author: https://github.com/Lubrsi
Commit: https://github.com/LadybirdBrowser/ladybird/commit/d185c2c28c4
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2791
Reviewed-by: https://github.com/gmta
Reviewed-by: https://github.com/shannonbooth

Libraries/LibWeb/WebGL/WebGLRenderbuffer.cpp

@@ -4,6 +4,7 @@
  * SPDX-License-Identifier: BSD-2-Clause
  */
 
+#include <LibJS/Runtime/Realm.h>
 #include <LibWeb/Bindings/WebGLRenderbufferPrototype.h>
 #include <LibWeb/WebGL/WebGLRenderbuffer.h>
 
@@ -11,8 +12,13 @@ namespace Web::WebGL {
 
 GC_DEFINE_ALLOCATOR(WebGLRenderbuffer);
 
-WebGLRenderbuffer::WebGLRenderbuffer(JS::Realm& realm)
-    : WebGLObject(realm, 0)
+GC::Ptr<WebGLRenderbuffer> WebGLRenderbuffer::create(JS::Realm& realm, GLuint handle)
+{
+    return realm.heap().allocate<WebGLRenderbuffer>(realm, handle);
+}
+
+WebGLRenderbuffer::WebGLRenderbuffer(JS::Realm& realm, GLuint handle)
+    : WebGLObject(realm, handle)
 {
 }
 

Libraries/LibWeb/WebGL/WebGLRenderbuffer.h

@@ -15,10 +15,12 @@ class WebGLRenderbuffer final : public WebGLObject {
     GC_DECLARE_ALLOCATOR(WebGLRenderbuffer);
 
 public:
+    static GC::Ptr<WebGLRenderbuffer> create(JS::Realm& realm, GLuint handle);
+
     virtual ~WebGLRenderbuffer();
 
 protected:
-    explicit WebGLRenderbuffer(JS::Realm&);
+    explicit WebGLRenderbuffer(JS::Realm&, GLuint handle);
 };
 
 }

Libraries/LibWeb/WebGL/WebGLRenderingContextBase.idl

@@ -71,7 +71,7 @@ interface mixin WebGLRenderingContextBase {
     WebGLBuffer? createBuffer();
     WebGLFramebuffer? createFramebuffer();
     WebGLProgram? createProgram();
-    [FIXME] WebGLRenderbuffer? createRenderbuffer();
+    WebGLRenderbuffer? createRenderbuffer();
     WebGLShader? createShader(GLenum type);
     WebGLTexture? createTexture();
 

Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp

@@ -424,6 +424,15 @@ public:
             continue;
         }
 
+        if (function.name == "createRenderbuffer"sv) {
+            function_impl_generator.append(R"~~~(
+    GLuint handle = 0;
+    glGenRenderbuffers(1, &handle);
+    return WebGLRenderbuffer::create(m_realm, handle);
+)~~~");
+            continue;
+        }
+
         if (function.name == "shaderSource"sv) {
             function_impl_generator.append(R"~~~(
     Vector<GLchar*> strings;