mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-26 12:17:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Correct typos for user validity of form elements on submission

Browse source 
The spec and comments say "set field's user validity to true", but we
now actually set it to true and not false.

This passes one subtest in WPT's css/selectors/user-valid.html.
This commit is contained in:
CountBleck 2025-08-13 21:52:55 -07:00 • committed by Jelle Raaijmakers
commit d49fb169bc
Notes: github-actions[bot] 2025-08-14 09:56:16 +00:00
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/HTML/HTMLFormElement.cpp
View file

@ -131,11 +131,11 @@ WebIDL::ExceptionOr<void> HTMLFormElement::submit_form(GC::Ref<HTMLElement> subm
// NOTE: Only input, select and textarea elements have a user validity flag.
// See https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#user-validity
if (is<HTMLInputElement>(*element)) {
(&as<HTMLInputElement>(*element))->set_user_validity(false);
(&as<HTMLInputElement>(*element))->set_user_validity(true);
} else if (is<HTMLSelectElement>(*element)) {
(&as<HTMLSelectElement>(*element))->set_user_validity(false);
(&as<HTMLSelectElement>(*element))->set_user_validity(true);
} else if (is<HTMLTextAreaElement>(*element)) {
(&as<HTMLTextAreaElement>(*element))->set_user_validity(false);
(&as<HTMLTextAreaElement>(*element))->set_user_validity(true);
}
}