mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-25 11:48:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Add missing StyleInvalidationReason for HTMLDialogElement

Browse source 
We were accidentally using NodeRemove instead of a unique reason.
This commit is contained in:
Andreas Kling 2025-08-18 23:20:20 +02:00 • committed by Jelle Raaijmakers
commit ec2b568919
Notes: github-actions[bot] 2025-08-20 07:16:50 +00:00
2 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/DOM/Node.h
View file

@ -63,6 +63,7 @@ enum class ShouldComputeRole {
X(EditingInsertion) \
X(ElementAttributeChange) \
X(ElementSetShadowRoot) \
X(HTMLDialogElementSetIsModal) \
X(HTMLHyperlinkElementHrefChange) \
X(HTMLIFrameElementGeometryChange) \
X(HTMLInputElementSetChecked) \

2
Libraries/LibWeb/HTML/HTMLDialogElement.cpp
View file

@ -467,7 +467,7 @@ void HTMLDialogElement::set_is_modal(bool is_modal)
if (m_is_modal == is_modal)
return;
m_is_modal = is_modal;
invalidate_style(DOM::StyleInvalidationReason::NodeRemove);
invalidate_style(DOM::StyleInvalidationReason::HTMLDialogElementSetIsModal);
}
// https://html.spec.whatwg.org/multipage/interactive-elements.html#the-dialog-element:is-valid-invoker-command-steps