773 commits

Author	SHA1	Message	Date
Andrew Kaster	4af0daf3eb	LibWeb: Check actual WorkerGlobalScope subclass to set top level origin ... Checking against DedicatedWorkerHost was probably a typo.	2025-05-18 17:50:05 -06:00
Andrew Kaster	62592c19fe	LibWeb: Reorganize EmbedderPolicy to shrink the size by 8 bytes	2025-05-18 17:50:05 -06:00
Andrew Kaster	b10a98b0cb	LibWeb: Move name attribute to WorkerGlobalScope from subclasses ... Also refactor the other properties of WorkerGlobalScope to match the spec better.	2025-05-18 17:50:05 -06:00
Sam Atkins	eec4365542	LibWeb/CSS: Extract SerializationMode into its own header ... Prep for using this to serialize dimension types, and perhaps other things in the future.	2025-05-17 07:53:24 +01:00
Jelle Raaijmakers	1c77b42a44	LibWeb: Add two FIXMEs about input events' missing .data value ... For both `<input>` and `<textarea>` elements, we actually need to provide the input events with the strings that were added to them.	2025-05-17 00:29:19 +02:00
Jelle Raaijmakers	ac46ec0b2e	LibWeb: Start integrating the editing API with user keyboard input ... This reworks EventHandler so text insertion, backspace, delete and return actions are now handled by the Editing API. This was the whole point of the execCommand spec, to provide an implementation of both editing commands and the expected editing behavior on user input. Responsibility of firing the `input` event is moved from EventHandler to the Editing API, which also gets rid of duplicate events whenever dealing with `<input>` or `<textarea>` events. The `beforeinput` event still needs to be fired by `EventHandler` however, since that is never fired by `execCommand()`.	2025-05-17 00:29:19 +02:00
Tim Ledbetter	2903defcfc	Revert "LibJS+LibWeb: Return Vector<PropertyKey> from… ... internal_own_property_keys" This reverts commit 5ee810f772.	2025-05-16 06:33:09 +01:00
Sam Atkins	3f18331594	LibWeb/HTML: Do not allow named window targeting with noopener ... Corresponds to dfdafb4b29 We fail the test for this, but we actually do create the separate popup windows correctly (when popups aren't blocked!) but the test checks `window.name` which we incorrectly return the empty string for. https://wpt.live/html/browsers/windows/auxiliary-browsing-contexts/named-lookup-noopener.html	2025-05-16 10:21:09 +12:00
Sam Atkins	08419a6d8f	LibWeb/HTML: Correct show_popover() invocations ... Corresponds to 47f854c66e	2025-05-16 10:21:09 +12:00
Sam Atkins	2efad4c941	LibWeb/HTML: Fire load event for non-string javascript: URLs ... Corresponds to 8abe559982 The relevant test doesn't pass, so we're probably missing some other part of this mechanism: https://wpt.live/html/semantics/embedded-content/the-embed-element/embed-javascript-url.html	2025-05-16 10:21:09 +12:00
Aliaksandr Kalenik	5ee810f772	LibJS+LibWeb: Return Vector<PropertyKey> from internal_own_property_keys ... By doing that we avoid lots of `PropertyKey` -> `Value` -> `PropertyKey` transforms, which are quite expensive because of underlying `FlyString` -> `PrimitiveString` -> `FlyString` conversions. 10% improvement on MicroBench/object-keys.js	2025-05-15 14:12:18 -04:00
Timothy Flynn	7280ed6312	Meta: Enforce newlines around namespaces ... This has come up several times during code review, so let's just enforce it using a new clang-format 20 option.	2025-05-14 02:01:59 -06:00
mikiubo	89e0896cd7	LibWeb: Implement XML Char validation for Text node serialization ... With this fix, the second test in domparsing/innerhtml-01.xhtml passes.	2025-05-14 18:18:08 +12:00
Glenn Skrzypczak	5c578b6057	LibWeb/HTML: Implement report_validity ... This implements the previously stubbed out `report_validity` method. The specification is not very clear on how to exactly report the validity. For now, we bring the first visible invalid control into view and focus it. In the future, however, it would make sense to support more complex scenarios and be more aligned with the other implementations.	2025-05-14 09:39:12 +12:00
Aliaksandr Kalenik	bb53485dea	LibJS+LibWeb: Add fast path for builtin iterators in iterator_step() ... We already have fast path for built-in iterators that skips `next()` lookup and iteration result object allocation applied for `for..of` and `for..in` loops. This change extends it to `iterator_step()` to cover `Array.from()`, `[...arr]` and many other cases. Makes following function go 2.35x faster on my computer: ```js (function f() { let arr = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]; for (let i = 0; i < 1000000; i++) { let [a, ...rest] = arr; } })(); ```	2025-05-13 15:14:25 +03:00
Daniel Bertalan	a2167f126d	Everywhere: Fix trivial -Wunnecessary-virtual-specifier instances ... - `Threading::Thread` is not polymorphic, there is no need for a virtual destructor. - `HTMLAnchorElement::has_download_preference` isn't overridden by anything. This warning was introduced in llvm/llvm-project#131188.	2025-05-12 11:40:45 -06:00
Mikkel Krautz	c48a78e37f	LibWeb: Fix copyright headers with inconsistent > characters	2025-05-12 11:21:04 -06:00
InvalidUsernameException	029bcf13fd	Libweb: Invalidate layout for the value-attribute of li-elements	2025-05-11 01:14:31 +02:00
InvalidUsernameException	370098514a	LibWeb: Invalidate layout for ol-attributes that affect it	2025-05-11 01:14:31 +02:00
Andreas Kling	263b125782	LibWeb: Let HTMLTokenizer walk over code points instead of UTF-8 ... Instead of using UTF-8 iterators to traverse the HTMLTokenizer input stream one code point at a time, we now do a one-shot conversion up front from the input encoding to a Vector<u32> of Unicode code points. This simplifies the tokenizer logic somewhat, and ends up being faster as well, so win-win. 1.02x speedup on Speedometer 2.1	2025-05-11 01:13:20 +02:00
Timothy Flynn	30e8f3f1ad	LibWeb: Update the <details> layout tree when it is opened/closed ... Otherwise, the arrow painted next to the <details> element does not update. Using a screenshot test here because apparently the direction of the arrow has no effect on the layout or paint trees.	2025-05-09 21:37:14 +02:00
Andreas Kling	f61df9d34c	LibWeb: Don't throw away UA shadow trees willy-nilly ... We were unnecessarily discarding the shadow trees of various elements when they were removed or detached from the DOM. This especially caused a *lot* of churn when creating input elements via setting .innerHTML on something. We ended up building each input element's shadow tree 3 times instead of 1. The original issue that we were trying to solve by discarding shadow trees appears to have been solved elsewhere, and nothing else seems to break by just allowing them to remain in place. 1.05x speedup on Speedometer's TodoMVC-jQuery.	2025-05-09 12:49:04 -04:00
Kenneth Myhra	6941b63890	LibWeb: Add {,de}serialization steps for ImageData	2025-05-09 02:12:01 +12:00
Kenneth Myhra	5b4644d198	LibWeb: Use WebIDL types for IDL exposed attributes	2025-05-09 02:12:01 +12:00
Sam Atkins	a8529629e2	LibWeb/HTML: Update "is script closable" to current spec ... Corresponds to d7fc63a84a and 7a48703e77	2025-05-08 10:39:34 +01:00
Francesco Gazzetta	5610f5a865	LibWeb/HTML: Add missing include to CanvasRenderingContext2D.cpp ... Fixes linking of CanvasRenderingContext2D on some systems: [2959/3075] Linking CXX shared library lib/liblagom-web.so.0.0.0 FAILED: lib/liblagom-web.so.0.0.0 : && /nix/store/f0m6caffiykyvsjim9376a3hx2yj2ghj-gcc-wrapper-14.2.1.20250322/bin/g++ -fPIC -O3 -DNDEBUG -fstack-protector-strong -Wl,-z,defs -Wl,--no-undefined -Wl,--no-allow-shlib-undefined -Wl,--dependency-file=Lagom/Libraries/LibWeb/CMakeFiles/LibWeb.dir/link.d -shared -Wl,-soname,liblagom-web.so.0 -o lib/liblagom-web.so.0.0.0 @CMakeFiles/LibWeb.rsp && : /nix/store/hzw38c3f7s0w200cgk9645z53al7k8lw-binutils-2.44/bin/ld: Lagom/Libraries/LibWeb/CMakeFiles/LibWeb.dir/HTML/CanvasRenderingContext2D.cpp.o: in function `Web::HTML::CanvasRenderingContext2D::context_attributes_from_options(JS::VM&, JS::Value) [clone .localalias]': CanvasRenderingContext2D.cpp:(.text+0x355a): undefined reference to `JS::Value::to_boolean() const' /nix/store/hzw38c3f7s0w200cgk9645z53al7k8lw-binutils-2.44/bin/ld: CanvasRenderingContext2D.cpp:(.text+0x38e6): undefined reference to `JS::Value::to_boolean() const' /nix/store/hzw38c3f7s0w200cgk9645z53al7k8lw-binutils-2.44/bin/ld: CanvasRenderingContext2D.cpp:(.text+0x3d67): undefined reference to `JS::Value::to_boolean() const' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. Co-authored-by: Timothy Flynn <trflynn89@pm.me>	2025-05-07 16:53:09 -04:00
Andreas Kling	183c847c80	LibJS: Cache PutById to setters in the prototype chain ... This is *extremely* common on the web, but barely shows up at all in JavaScript benchmarks. A typical example is setting Element.innerHTML on a HTMLDivElement. HTMLDivElement doesn't have innerHTML, so it has to travel up the prototype chain until it finds it. Before this change, we didn't cache this at all, so we had to travel the prototype chain every time a setter like this was used. We now use the same mechanism we already had for GetBydId and cache PutById setter accesses in the prototype chain as well. 1.74x speedup on MicroBench/setter-in-prototype-chain.js	2025-05-05 15:21:43 +02:00
Jelle Raaijmakers	71665fa504	LibWeb: Scale font size by 1.15 for line-height: normal ... Browsers such as Chrome and Firefox apply an arbitrary scale to the current font size if `normal` is used for `line-height`. Firefox uses 1.2 while Chrome uses 1.15. Let's go with the latter for now, it's relatively easy to change if we ever want to go back on that decision. This also requires updating the expectations for a lot of layout tests. The upside of this is that it's a bit easier to compare our layout results to other browsers', especially Chrome.	2025-05-05 13:15:56 +02:00
Timothy Flynn	ea77092100	LibWeb: Begin implementing SharedWorker ... Shared workers are essentially just workers that may be accessed from scripts within the same origin. There are plenty of FIXMEs here (mostly building on existing worker FIXMEs that are already in place), but this lets us run the shared worker variants of WPT tests.	2025-05-02 17:48:02 -04:00
Timothy Flynn	469d5ccc4b	LibWeb: Add FIXME about Worker's constructor's scriptURL parameter ... TrustedScriptURL is its own interface that we haven't implemented yet.	2025-05-02 17:48:02 -04:00
Sam Atkins	d301510ab2	Everywhere: Correct "FIMXE" typo	2025-04-30 17:38:38 +01:00
Andrew Kaster	e5465ff8e5	LibWeb: Crash less when the main thread exits while trying to render ... Attach a 'job' to the main thread event loop, trusting that the event loop implementation will cancel it when asked to quit. This is something that our Unix implementation does, but isn't strictly part of the contract of EventLoopImplementation.	2025-04-29 09:51:22 -06:00
Jelle Raaijmakers	35efd4d14b	LibWeb+LibGfx: Support alpha in CanvasRenderingContext2D ... This is implemented by these related changes: * The Skia alpha type 'Opaque' is selected for surfaces that were created with the intention of not having an alpha channel. Previously we were simply creating one with alpha. * Clearing now happens through Skia's `clear()` which always uses the source color's value for the result, instead of setting all values to 0. * CanvasRenderingContext2D selects a different clearing color based on the `alpha` context attribute's value.	2025-04-29 13:51:23 +02:00
Jelle Raaijmakers	fac0f82031	LibWeb: Add CanvasRenderingContext2D context attribute parsing ... Makes `context.getContextAttributes()` work.	2025-04-29 13:51:23 +02:00
Gingeh	aa9f556500	LibWeb: Light dismiss dialogs on click	2025-04-28 19:41:38 -06:00
Gingeh	1f1884da54	LibWeb: Light dismiss popovers on click	2025-04-28 19:41:38 -06:00
Hikmat Jafarli	bd9d489370	LibWeb: Re-evaluate the style block when the type attribute changes	2025-04-29 01:01:02 +02:00
Andreas Kling	4d17707b26	LibJS: Store bytecode VM program counter in ExecutionContext ... This way it's always automatically correct, and we don't have to manually flush it in push_execution_context(). ~7% speedup on the MicroBench/call* tests :^)	2025-04-28 21:12:48 +02:00
teaalltr	a3e485e2d0	LibWeb: Add fast_is for span and div	2025-04-28 19:46:05 +01:00
Shannon Booth	8a3c66d8a6	LibWeb: Make a bunch of CSP classes not realm associated ... These are not associated with a javascript realm, so to avoid confusion about which realm these need to be created in, make all of these objects a GC::Cell, and deal with the fallout.	2025-04-28 12:41:28 +02:00
Shannon Booth	420949b134	LibWeb/HTML: Make Navigation navigate event trusted ... Fixes WPT test: https://wpt.live/navigation-api/navigate-event/signal-abort-intercept.html	2025-04-27 07:54:02 -04:00
Shannon Booth	6032827fe7	LibWeb/HTML: Inform navigation API about frame container destruction	2025-04-27 07:54:02 -04:00
Shannon Booth	31a3bc3681	LibWeb: Implement 'State-preserving atomic move integration' ... This was recently added to both the HTML and DOM specifications, introducing the new moveBefore DOM API, as well as the new internal 'removing steps'. See: * 432e8fb * eaf2ac7	2025-04-26 08:45:37 -06:00
Timothy Flynn	0e2036d6c2	LibWeb: Temporarily disable site isolation for subframes ... We don't yet support out-of-process subframes. Explicitly disable even attempting to isolate subframes. Otherwise, navigating a subframe to a non-same-site URL would actually cause the top-level frame to navigate with our current implementation.	2025-04-26 10:15:47 -04:00
Timothy Flynn	e52c09ad4c	LibWeb: Avoid copying a URL needlessly during subframe navigation ... Noticed a clangd warning for this while looking at a subframe site isolation issue.	2025-04-26 10:15:47 -04:00
Timothy Flynn	4e298db4f5	LibWeb: Update FIXMEs about FrozenArray with more up-to-date description ... We could support FrozenArray pretty easily here, but we would regress on SameObject handling.	2025-04-25 16:43:43 +02:00
Timothy Flynn	ad34fdad48	LibWeb: Convert trivial attributes to FrozenArray	2025-04-25 16:43:43 +02:00
Shannon Booth	a2cca59516	LibWeb+LibWebView+Services: Add IPC for starting WebWorker of a type ... The provides some of the plumbing for a WebContent process to spin up a WebWorker that is not just a dedicated worker.	2025-04-25 14:07:51 +02:00
Shannon Booth	041ff0c7ff	LibWeb/HTML: Hook up a WorkerAgent for web workers	2025-04-25 14:07:51 +02:00
Shannon Booth	5290ebfe19	LibJS: Switch Agent [[CanBlock]] slot to a enum member ... It turns out it was a mistake to make this a virtual since ServiceWorkerAgents are effectively the exact same as DedicatedWorkerAgents and SharedWorkerAgents just with [[CanBlock]] set to false.	2025-04-25 14:07:51 +02:00