mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-03 08:08:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9
46948 commits 1 branch 0 tags 525 MiB
Commit graph

46948 commits

This branch
This branch
All branches
Author SHA1 Message Date
Lucas CHOLLET
782b1d20f5 LibGfx: Remove Bitmap::load_from_fd_and_close() 
The method was only used in `load_from_file(StringView path)` and
replacing it with `load_from_file(NonnullOwnPtr<Core::File>)` is very
straightforward.
 2023-02-17 10:36:03 +01:00
Karol Kosek
be717edd33 PixelPaint: Propagate errors from making tool property widgets 2023-02-16 23:36:58 +00:00
Ali Mohammad Pur
b409a40377 LibJS: Actually escape \n|\r|LS|PS when escaping RegExp.source 
We were previously encoding them as `\<literal newline>`, which is just
all sorts of wrong :P
 2023-02-16 23:32:35 +01:00
Ben Wiederhake
e3f3470a6c Presenter: Fix unintentional U+00A0 codepoint in text 
Found using git grep -FIn $'\u00a0'

I just got bit by this type of bug in a different project, and was
wondering whether Serenity has this problem, too. See also:
https://dhwthompson.com/2019/my-favourite-git-commit
 2023-02-16 22:07:07 +00:00
Ali Mohammad Pur
bcfbe0fbf7 LibJS: Manually loop over escaped regex pattern instead of ::replace() 
This makes it ever-so-slightly faster, but more importantly, it fixes
the bug where a `/\//` regex's `source` property would return `\\/`
("\\\\/") instead of `\/` due to the existing '/' -> '\/' replace()
call.
 2023-02-16 21:03:19 +01:00
Ali Mohammad Pur
a8bcb901c0 LibJS: Escape printed strings making them proper string literals 
Previously we just printed '"' string-contents '"', which was not a
proper string literal.
 2023-02-16 21:03:19 +01:00
Lucas CHOLLET
e8249d735d LibFileSystemAccessClient: Remove the deprecated API 
Concerned functions are:
 - try_request_file_read_only_approved_deprecated
 - try_request_file_deprecated
 - try_open_file_deprecated
 - try_save_file_deprecated

It also allows some simplifications in the implementation of the client.
 2023-02-16 20:11:52 +01:00
Timothy Flynn
ba40ef1f3a LibJS: Remove Value::to_deprecated_string_without_side_effects 2023-02-16 14:32:22 +01:00
Timothy Flynn
a2f1b80c36 Assistant+Spreadsheet: Convert usages of Value::TDSWOSE to Value::TSWOSE 2023-02-16 14:32:22 +01:00
Timothy Flynn
527edb55ad LibWeb: Convert usages of Value::TDSWOSE to Value::TSWOSE 2023-02-16 14:32:22 +01:00
Timothy Flynn
24e9cea524 LibJS: Convert remaining usages of Value::TDSWOSE to Value::TSWOSE 
Note the couple of cases using MUST are just debugging statements.
 2023-02-16 14:32:22 +01:00
Timothy Flynn
c17589a402 LibJS: Change Print's print_type helper to accept a StringView 
There's no benefit to accepting a fly string, and this will soon be
needed to be used with String.
 2023-02-16 14:32:22 +01:00
Timothy Flynn
bb64b49749 LibJS: Remove unused Reference::to_deprecated_string 2023-02-16 14:32:22 +01:00
Timothy Flynn
36d72a7f4c LibJS: Convert CanonicalNumericIndexString to use NumberToString 2023-02-16 14:32:22 +01:00
Timothy Flynn
9a5a4302d9 LibJS: Convert PropertyDescriptor's formatter to String 
And generally propagate OOM.
 2023-02-16 14:32:22 +01:00
Timothy Flynn
a73b8292ed LbJS: Convert exception-related usages of Value::TDSWOSE to String 
TDSWOSE being to_deprecated_string_without_side_effects.
 2023-02-16 14:32:22 +01:00
Timothy Flynn
3ffb6d9b5a LibJS: Define Value::to_string_without_side_effects for String 2023-02-16 14:32:22 +01:00
Timothy Flynn
dc4207323b LibJS: Remove the VM parameter from the NumberToString AO 
This will be needed by Value::to_string_without_side_effects, which can
be called in contexts without a VM (e.g. in AK::Format specializations).
So to_string_without_side_effects will need to be callable without a VM,
thus NumberToString must be as well.
 2023-02-16 14:32:22 +01:00
Timothy Flynn
7a7a649f5b LibJS: Define BigInt::to_string to complement to_deprecated_string 2023-02-16 14:32:22 +01:00
Timothy Flynn
b245300ba1 LibJS+Everywhere: Deprecate Value::to_string_without_side_effects 2023-02-16 14:32:22 +01:00
Karol Baraniecki
7fc7d4f8c6 su: Document the [-c command] option 2023-02-16 12:52:11 +00:00
Karol Baraniecki
040012a196 su: Correct brackets in documentation for the user option 
The `<brackets>` syntax usually suggests a required option, while the
`[brackets]` syntax an optional one. `user` is an optional argument.
 2023-02-16 12:52:11 +00:00
Karol Baraniecki
3c04d22e38 su: Only check for an interactive tty if a password is actually needed 2023-02-16 12:52:11 +00:00
Karol Baraniecki
a8a5707467 su: Allow to specify a command to be executed by -c 
su -c 'echo yeah'
 2023-02-16 12:52:11 +00:00
Tim Ledbetter
644a61c318 ImageViewer: Rename "Go Back" and "Go Forward" actions 
This commit renames "Go Back" to "Go to Previous" and "Go Forward" to
"Go to Next". This better reflects what the actions do.
 2023-02-16 12:26:41 +00:00
Tim Ledbetter
b983dc8807 ImageViewer: Make arrow key shortcuts work 
The user can now navigate to the previous and next image using the
left and right arrow keys respectively. These shortcuts were
previously not working.
 2023-02-16 12:26:41 +00:00
Ryan Liptak
2a32f8ad42 Base: Improve eye emoji and add mouth emoji 
👁️ - U+1FF41 EYE
Add a bit of shadow so that it works better on white backgrounds
👄 - U+1F444 MOUTH
 2023-02-16 12:07:21 +00:00
Niko
790f0c98c2 Base: Add some emoji 
New:
1F37E fully-qualified     # 🍾 E1.0 bottle with popping cork
1F38D fully-qualified     # 🎍 E0.6 pine decoration
1F960 fully-qualified     # 🥠 E5.0 fortune cookie
1F985 fully-qualified     # 🦅 E3.0 eagle
1FAC5 fully-qualified     # 🫅 E14.0 person with crown

Modified:
1F5FE fully-qualified     # 🗾 E0.6 map of Japan
 2023-02-16 12:28:11 +01:00
Nathan Ell
3b446b873e Ports/dos2unix: Update to 7.4.4 2023-02-16 12:27:52 +01:00
Federico Guerinoni
1296aa108b Ladybird: Close tab clicking wheel of the mouse 2023-02-16 11:26:44 +00:00
Lucas CHOLLET
d5f7771039 3DFileViewer: Don't unveil "/home/anon/Documents/3D Models" 
Usage of models is now done by `LibFileSystemAccessClient`.
 2023-02-16 10:56:01 +00:00
Lucas CHOLLET
851b887cd0 3DFileViewer: Set the window title name in load_file() 
This patch allows two things:
 - Factorizing code that was in main and the open action
 - Displaying the full path of non-unveiled paths

Indeed, looking for the path of a fd is not allowed if the file isn't
unveiled. By setting the title in `load_file()` we are actually relying
on the value returned by `LibFSAC` who is actually authorized to
retrieve the entire path.
 2023-02-16 10:56:01 +00:00
Lucas CHOLLET
95a03f8ed6 3DFileViewer: Don't try to open textures without LibFSASC 2023-02-16 10:56:01 +00:00
Lucas CHOLLET
9c2800fbb5 3DFileViewer: Port to Core::File 2023-02-16 10:56:01 +00:00
Lucas CHOLLET
b13695c9f4 LibGfx: Add a stream compatible overload of Bitmap::load_from_file() 2023-02-16 10:56:01 +00:00
Lucas CHOLLET
5b6e93f96a LibCore: Add MappedFile::map_from_file() 
This method relies on `map_from_fd_and_close()` but takes a `File`
instead of a fd.
 2023-02-16 10:56:01 +00:00
Lucas CHOLLET
3a95c8111d LibCore: Allow MappedFile to make File leak its fd 2023-02-16 10:56:01 +00:00
Lucas CHOLLET
0f4a8731fd LibCore: Forward declare MappedFile 2023-02-16 10:56:01 +00:00
Lucas CHOLLET
13b149b42e 3DFileViewer: Remove unnecessary tests when loading files 
These tests are already performed by `LibFileSystemAccessClient`.
 2023-02-16 10:56:01 +00:00
Lucas CHOLLET
f9e3a591d2 3DFileViewer: Use LibFSAC in GLContextWidget::load_path() 
It was the only function to not use the `LibFSAC`, it will allow us to:
 - Not unveil some file
 - Drop some tests on to-be-read-from file as they are performed in
   `LibFSAC`.
 2023-02-16 10:56:01 +00:00
Lucas CHOLLET
b4cea1c72e 3DFileViewer: Port MeshLoader and its child to the new Core::File 
As it was using the `lines()` method of `Core::DeprecatedFile`, this
patch also introduce the usage of `BufferedFile` to take advantage of
its API: `can_read_line()` and `read_line()`.
 2023-02-16 10:56:01 +00:00
Karol Kosek
83da3c5c3e PixelPaint: Add an option for making a Gradient with a secondary color 2023-02-16 10:50:58 +00:00
Karol Kosek
1ce2d7e674 PixelPaint: Put the main gradient color at the cursor 
It doesn't seem right to me that we are 'holding' a transparent color,
with the main color being on the opposite side.
 2023-02-16 10:50:58 +00:00
Karol Kosek
d27d19f012 PixelPaint: Set Tool on_*_color_change logic using virtual functions 
Previously, we were rewriting the on_primary_color_change in the Text
Tool and Gradient, which made the palette widget no longer update after
picking a color from an image. Additionally, it also crashed the program
after leaving the Gradient tool and trying to change color.
 2023-02-16 10:50:58 +00:00
Cameron Youell
cb96c892cc LibGUI: Add highlighting to UrlBox 2023-02-16 10:47:22 +00:00
Cameron Youell
dad70d8d6e LibGUI: Account for glyph_spacing() in spans 2023-02-16 10:47:22 +00:00
Timothy Flynn
32a01a60e7 LibUnicode: Remove non-iterative text segmentation algorithms 
They are now unused.
 2023-02-16 11:18:53 +01:00
Timothy Flynn
6ce7ec2eb3 LibUnicode: Use iterative text segmentation algorithms for titlecasing 2023-02-16 11:18:53 +01:00
Timothy Flynn
7cb956d17b LibJS: Use iterative text segmentation algorithms for Intl.Segmenter 
This uses the find-next and find-previous APIs instead of storing all
indices as a vector.
 2023-02-16 11:18:53 +01:00
Ben Wiederhake
9a7b3c145f Everywhere: Change all XXX into FIXME or remove as appropriate 2023-02-15 23:33:25 +01:00