145 commits

Author	SHA1	Message	Date
Tete17	8ab568bc76	LibWeb: Unify will_validate for form associated elements ... We had the same implementation in quiet a few places. With this change we unify them in a single place	2025-08-29 19:27:30 +01:00
Tete17	af88a43e9a	LibWeb: Unify check_validity for form associated elements	2025-08-29 19:27:30 +01:00
Tete17	44053ed3c2	LibWeb: Unify report_validity for form associated elements ... This function was implemented in a few classes but is a common element in all form associated elements and the functionality should be there. With these minimal changes we get to implement 4 idl functions for free.	2025-08-29 19:27:30 +01:00
Glenn Skrzypczak	89f94845cf	LibWeb/HTML: Use from_milliseconds_since_epoch directly ... Use `from_milliseconds_since_epoch` directly instead of converting to seconds first and calling `from_seconds_since_epoch`.	2025-08-27 15:10:06 +02:00
Glenn Skrzypczak	bd34b11ca2	LibWeb/HTML: Implement date conversions for month and week inputs ... This implements the conversion algorithms between strings and dates for inputs of the types month and week.	2025-08-27 15:10:06 +02:00
Tim Ledbetter	cb1a1a5cb5	LibWeb: Replace is<T>() with as_if<T>() where possible	2025-08-25 18:45:00 +02:00
Jelle Raaijmakers	ff5f80a196	LibWeb: Add HTMLElement::uses_button_layout() ... This suits the spec a bit better, and exposes the fact that we were allowing `::ImageButton` to use the button layout although it is never specified that it should do so. Tests were rebaselined for this.	2025-08-18 11:04:34 +01:00
Glenn Skrzypczak	c01dc5900a	LibWeb/HTML: Check all radio buttons in group for required attribute ... This fixes a bug in the algorithm for determining if radio buttons are missing their value. Previously it was only checked if the button itself is required. Now the algorithm checks if the radio button group contains a required radio button in order to determine if the value is required.	2025-08-17 22:27:14 +02:00
Glenn Skrzypczak	d25d62e74c	AK/Time+LibWeb/HTML: Fix ISO8601 week conversions ... This reimplements conversions between unix date times and ISO8601 weeks. The new algorithms also do not use loops, so they should be faster.	2025-08-14 11:05:28 -04:00
Glenn Skrzypczak	ec807d40dd	LibWeb/HTML: Correctly convert number to time/local datetime string ... This fixes a bug where non-zero milliseconds were previously not included if the second component was zero.	2025-08-14 11:05:28 -04:00
Glenn Skrzypczak	354fd56046	LibWeb/HTML: Step to next value without step mismatch ... Inputs now correctly step to the next valid value if they suffer a step mismatch.	2025-08-14 11:05:28 -04:00
Glenn Skrzypczak	a127f77602	LibWeb/HTML: Implement default value of range inputs ... Range inputs now always uses the default value if the value attribute is not set and the input is not dirty.	2025-08-14 11:05:28 -04:00
Glenn Skrzypczak	aea8650d8b	LibWeb/HTML: Enforce constraints on range inputs ... This extends the sanitization algorithm for range inputs in order to prevent overflow, underflow and step mismatch.	2025-08-14 11:05:28 -04:00
Glenn Skrzypczak	cac2ee41b9	LibWeb/HTML: Correctly compute whether element is mutable ... This adapts the implementation of `is_mutable` to align more closely with the spec. Specifically, it is now also taken into account whether the element is enabled.	2025-08-14 11:05:28 -04:00
Timothy Flynn	70db474cf0	LibJS+LibWeb: Port interned bytecode strings to UTF-16 ... This was almost a no-op, except we intern JS exception messages. So the bulk of this patch is porting exception messages to UTF-16.	2025-08-14 10:27:08 +02:00
Sam Atkins	4e92ab52e3	LibWeb/CSS: Rename CSSKeywordValue -> KeywordStyleValue ... The typed-om CSSKeywordValue will need to be a separate class.	2025-08-08 15:19:03 +01:00
Timothy Flynn	1bc80848fb	AK+LibWeb: Add a UTF-16 starts/ends with wrapper for a single code unit	2025-08-07 02:05:50 +02:00
Timothy Flynn	2dc0a3b3ce	AK: Add trim methods to Utf16String that skip allocation when not needed ... If the string does not begin with any of the provided code units, we do not need to create a new string.	2025-08-05 15:13:36 +02:00
Timothy Flynn	0efa98a57a	LibJS+LibWeb+WebContent: Port JS::PropertyKey to UTF-16 ... This has quite a lot of fall out. But the majority of it is just type or UDL substitution, where the changes just fall through to other function calls. By changing property key storage to UTF-16, the main affected areas are: * NativeFunction names must now be UTF-16 * Bytecode identifiers must now be UTF-16 * Module/binding names must now be UTF-16	2025-08-05 07:07:15 -04:00
Andreas Kling	77abe2a84d	LibWeb: Allow ImageProvider subclasses to visit additional GC edges ... More prep work for CSS content:image.	2025-07-28 22:46:27 +02:00
Timothy Flynn	5c561c1a53	LibWeb: Port node text content to UTF-16	2025-07-28 18:30:50 +02:00
Timothy Flynn	c8888609f4	LibWeb: Port the FormAssociatedElement value to UTF-16 ... This porting effort makes it pretty clear we will want a UTF-16-aware GenericLexer. But for now, we can actually make ASCII assumptions about what we are parsing, and act accordingly.	2025-07-28 12:25:11 +02:00
Timothy Flynn	8b6e3cb735	LibWeb+LibUnicode+WebContent: Port DOM:CharacterData to UTF-16 ... This replaces the underlying storage of CharacterData with Utf16String and deals with the fallout.	2025-07-24 19:00:20 +02:00
Glenn Skrzypczak	6e6507c8c5	LibWeb/HTML: Sanitize email input with multiple attribute ... This implements the missing part of the value sanitization algorithm for email inputs with the multiple attribute.	2025-07-22 23:02:33 +01:00
Sam Atkins	632ce9523b	LibWeb/CSS: Add :unchecked pseudo-class ... This just got added to the Selectors spec: b78c97c19d It's thus missing from the HTML spec and WPT, but I figured it was simple enough to add.	2025-07-15 21:27:44 +02:00
Sam Atkins	af17f38bbf	LibWeb/HTML: Implement and use "optional value" ... Corresponds to f3444c23ff Also import a test.	2025-07-08 17:08:39 +01:00
circl	7152821c8f	LibWeb: Don't mark <input type="color"> as closed until the picker is ... The color picker implementation allows for live updates to the input element until the final color is confirmed by the user, but previously it was marked as closed immediately after the first update.	2025-06-27 15:12:47 +01:00
Timothy Flynn	3171d57639	LibWeb: Restore flags to prevent formatting timestamps as local time ... The flag to stringify these timestamps as UTC was errantly dropped in 6fb2be96bf. This was causing test-web to fail in time zones other than GMT+0.	2025-06-25 23:41:04 +02:00
Sam Atkins	423cdd447d	LibWeb+LibGfx: Apply editorial punctuation/whitespace/markup fixes ... Corresponds to d426109ea1 and fd08f81d06	2025-06-25 03:12:19 +12:00
Tomasz Strejczek	6fb2be96bf	Everywhere: Replace DateTime::to_string() with UnixDateTime::to_string() ... Replace LibCore::DateTime::to_string() with AK::UnixDateTime::to_string(). Remove unncessary #include <LibCore/DateTime.h>.	2025-06-19 18:42:45 -06:00
Saksham Mittal	c52c05555b	LibWeb: Don't place cursor on certain <input> elements ... For example, button inputs shouldn't have a cursor displayed in their text since they're not editable, and are not meant to be editable. Fixes #4140 Co-authored-by: Sam Atkins <sam@ladybird.org>	2025-06-02 11:38:38 +01:00
Shannon Booth	937994cfaa	LibWeb: Make Environment's top level origin nullable ... This matches the definition in the spec, and is also a step towards removing the default constructor of URL::Origin.	2025-05-27 14:48:43 +12:00
Gingeh	3fe148f2d4	LibWeb: Implement the :default pseudo-class	2025-05-24 10:31:34 +01:00
Gingeh	7acc0f4a42	LibWeb: Implement :required/:optional pseudo-classes	2025-05-24 10:31:34 +01:00
Shannon Booth	579730d861	LibWeb: Prefer using equals_ignoring_ascii_case ... Which has an optmization if both size of the string being passed through are FlyStrings, which actually ends up being the case in some places during selector matching comparing attribute names. Instead of maintaining more overloads of Infra::is_ascii_case_insensitive_match, switch everything over to equals_ignoring_ascii_case instead.	2025-05-21 13:45:02 +01:00
Jelle Raaijmakers	1c77b42a44	LibWeb: Add two FIXMEs about input events' missing .data value ... For both `<input>` and `<textarea>` elements, we actually need to provide the input events with the strings that were added to them.	2025-05-17 00:29:19 +02:00
Glenn Skrzypczak	5c578b6057	LibWeb/HTML: Implement report_validity ... This implements the previously stubbed out `report_validity` method. The specification is not very clear on how to exactly report the validity. For now, we bring the first visible invalid control into view and focus it. In the future, however, it would make sense to support more complex scenarios and be more aligned with the other implementations.	2025-05-14 09:39:12 +12:00
Andreas Kling	f61df9d34c	LibWeb: Don't throw away UA shadow trees willy-nilly ... We were unnecessarily discarding the shadow trees of various elements when they were removed or detached from the DOM. This especially caused a *lot* of churn when creating input elements via setting .innerHTML on something. We ended up building each input element's shadow tree 3 times instead of 1. The original issue that we were trying to solve by discarding shadow trees appears to have been solved elsewhere, and nothing else seems to break by just allowing them to remain in place. 1.05x speedup on Speedometer's TodoMVC-jQuery.	2025-05-09 12:49:04 -04:00
Jelle Raaijmakers	71665fa504	LibWeb: Scale font size by 1.15 for line-height: normal ... Browsers such as Chrome and Firefox apply an arbitrary scale to the current font size if `normal` is used for `line-height`. Firefox uses 1.2 while Chrome uses 1.15. Let's go with the latter for now, it's relatively easy to change if we ever want to go back on that decision. This also requires updating the expectations for a lot of layout tests. The upside of this is that it's a bit easier to compare our layout results to other browsers', especially Chrome.	2025-05-05 13:15:56 +02:00
Glenn Skrzypczak	d4076ec9fa	LibWeb/HTML: Signal a type change ... Type changes are now signaled to radio buttons. This causes other radio buttons in the group to be unchecked if the input element is a checked radio button after the type change.	2025-04-23 07:20:02 +01:00
Glenn Skrzypczak	5f75558646	LibWeb/HTML: Correctly reset selection on type change ... The selection now gets reset to the beginning of the control if the type changes from an unselectable type to a selectable type.	2025-04-23 07:20:02 +01:00
Andreas Kling	545ed08519	LibWeb: Add debug logging of reasons for layout tree update	2025-04-21 00:31:08 +02:00
Andreas Kling	a6dfc74e93	LibWeb: Only set prototype once for object with IDL interface ... Before this change, we were going through the chain of base classes for each IDL interface object and having them set the prototype to their prototype. Instead of doing that, reorder things so that we set the right prototype immediately in Foo::initialize(), and then don't bother in all the base class overrides. This knocks off a ~1% profile item on Speedometer 3.	2025-04-20 18:43:11 +02:00
Glenn Skrzypczak	9c758e5f65	LibWeb/HTML: Correctly parse milliseconds in time inputs ... This commit brings the way we parse time inputs closer to the spec by no longer ignoring milliseconds in time strings.	2025-04-19 07:09:36 -04:00
sideshowbarker	cfc1fd7305	LibWeb: Handle “default step”/“step scale factor” for more input types ... This change adds “default step” and “step scale factor” handling for all remaining HTMLInputElement input types for which the spec defines such and that we didn’t yet have handling for.	2025-04-14 09:43:16 +01:00
Sam Atkins	d855adf767	LibWeb: Add slider- prefix to slider pseudo-element names ... Corresponds to 9549bb8951	2025-04-11 21:27:47 +01:00
Viktor Szépe	5cc371d54c	LibWeb: Fix typos - act II	2025-04-09 15:05:20 +01:00
Andreas Kling	d856858015	LibWeb: Cache and reuse inline style for text input shadow trees ... Instead of reparsing the style attributes every time we instantiate the internal shadow tree for a text input element, we now parse them once (in the internal CSS realm) and reuse them for all elements. Roughly a ~10% speedup on Speedometer 2.1 :^)	2025-03-25 23:57:00 +00:00
Andreas Kling	a6836054cc	LibWeb: Don't drop entire layout tree on input element src change	2025-03-25 07:31:42 +00:00
Andreas Kling	53da8893ac	LibJS: Replace PropertyKey(char[]) with PropertyKey(FlyString) ... ...and deal with the fallout.	2025-03-24 22:27:17 +00:00