mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-10-18 06:00:27 +00:00
d45f8a3081
Some checks are pending
CI / macOS, arm64, Sanitizer, Clang (push) Waiting to run
CI / Linux, x86_64, Fuzzers, Clang (push) Waiting to run
CI / Linux, x86_64, Sanitizer, GNU (push) Waiting to run
CI / Linux, x86_64, Sanitizer, Clang (push) Waiting to run
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
We already had IC support in PutById for the following cases:
- Changing an existing own property
- Calling a setter located in the prototype chain
This was enough to speed up code where structurally identical objects
(same shape) are processed in a loop:
```js
const arr = [{ a: 1 }, { a: 2 }, { a: 3 }];
for (let obj of arr) {
obj.a += 1;
}
```
However, creating structurally identical objects in a loop was still
slow:
```js
for (let i = 0; i < 10_000_000; i++) {
const o = {};
o.a = 1;
o.b = 2;
o.c = 3;
}
```
This change addresses that by adding a new IC type that caches both the
source and target shapes, allowing property additions to be fast-pathed
by directly jumping to the shape that already includes the new property.
77 lines
2.7 KiB
C++
77 lines
2.7 KiB
C++
/*
|
|
* Copyright (c) 2024, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/Bindings/ExceptionOrUtils.h>
|
|
#include <LibWeb/WebIDL/ObservableArray.h>
|
|
|
|
namespace Web::WebIDL {
|
|
|
|
GC_DEFINE_ALLOCATOR(ObservableArray);
|
|
|
|
GC::Ref<ObservableArray> ObservableArray::create(JS::Realm& realm)
|
|
{
|
|
auto prototype = realm.intrinsics().array_prototype();
|
|
return realm.create<ObservableArray>(realm, prototype);
|
|
}
|
|
|
|
ObservableArray::ObservableArray(JS::Realm& realm, Object& prototype)
|
|
: JS::Array(realm, prototype)
|
|
{
|
|
}
|
|
|
|
void ObservableArray::visit_edges(JS::Cell::Visitor& visitor)
|
|
{
|
|
Base::visit_edges(visitor);
|
|
visitor.visit(m_on_set_an_indexed_value);
|
|
visitor.visit(m_on_delete_an_indexed_value);
|
|
}
|
|
|
|
void ObservableArray::set_on_set_an_indexed_value_callback(SetAnIndexedValueCallbackFunction&& callback)
|
|
{
|
|
m_on_set_an_indexed_value = GC::create_function(heap(), move(callback));
|
|
}
|
|
|
|
void ObservableArray::set_on_delete_an_indexed_value_callback(DeleteAnIndexedValueCallbackFunction&& callback)
|
|
{
|
|
m_on_delete_an_indexed_value = GC::create_function(heap(), move(callback));
|
|
}
|
|
|
|
JS::ThrowCompletionOr<bool> ObservableArray::internal_set(JS::PropertyKey const& property_key, JS::Value value, JS::Value receiver, JS::CacheableSetPropertyMetadata* metadata, PropertyLookupPhase phase)
|
|
{
|
|
if (property_key.is_number() && m_on_set_an_indexed_value)
|
|
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_set_an_indexed_value->function()(value); }));
|
|
return TRY(Base::internal_set(property_key, value, receiver, metadata, phase));
|
|
}
|
|
|
|
JS::ThrowCompletionOr<bool> ObservableArray::internal_delete(JS::PropertyKey const& property_key)
|
|
{
|
|
if (property_key.is_number() && m_on_delete_an_indexed_value) {
|
|
auto maybe_value_and_attributes = indexed_properties().get(property_key.as_number());
|
|
JS::Value deleted_value;
|
|
if (maybe_value_and_attributes.has_value())
|
|
deleted_value = maybe_value_and_attributes->value;
|
|
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_delete_an_indexed_value->function()(deleted_value); }));
|
|
}
|
|
return JS::Array::internal_delete(property_key);
|
|
}
|
|
|
|
JS::ThrowCompletionOr<void> ObservableArray::append(JS::Value value)
|
|
{
|
|
if (m_on_set_an_indexed_value)
|
|
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_set_an_indexed_value->function()(value); }));
|
|
indexed_properties().append(value);
|
|
return {};
|
|
}
|
|
|
|
void ObservableArray::clear()
|
|
{
|
|
while (!indexed_properties().is_empty()) {
|
|
auto deleted_value = indexed_properties().storage()->take_first().value;
|
|
MUST(m_on_delete_an_indexed_value->function()(deleted_value));
|
|
}
|
|
}
|
|
|
|
}
|