Pokechu22
694f4b7acb
Software: Panic alert on specular lighting use - is it actually being used by things other than Mario Tennis?
2023-03-04 09:15:36 -08:00
Pokechu22
fca66eaf53
Revert "Down this route lies madness"
...
This reverts commit 6cad59caf4add6d36f03d21d1785e445ca9bd999.
2023-03-04 09:15:36 -08:00
Pokechu22
8ab57474a0
Down this route lies madness
2023-03-04 09:15:36 -08:00
Pokechu22
a7cd938ef7
Revert "Remove front-facing check for specular lights"
...
This reverts commit 0b425bbb41daa1f613d99641cf8da35cc901a4a1. The patent says this exists.
2023-03-04 09:15:36 -08:00
Pokechu22
137b81338f
Remove front-facing check for specular lights
...
This is basically a copy of the diffusefunc; it doesn't make sense for it to be implemented in both places (though I haven't confirmed that it isn't)
2023-03-04 09:15:36 -08:00
Pokechu22
8a53fe4f46
Correctly handle attenuation func of none
2023-03-04 09:15:36 -08:00
Pokechu22
c63ea902f0
Revert "Further refactoring attempt"
...
This reverts commit 334ca8df73c2686ac1c793313fc70c97a6142bea.
2023-03-04 09:15:36 -08:00
Pokechu22
0c34ca7b89
Further refactoring attempt
2023-03-04 09:15:36 -08:00
Pokechu22
f419a40558
Refactor LightingShaderGen further
2023-03-04 09:15:35 -08:00
Pokechu22
a5e531d9fa
Remove normalization of distAttn
...
distAttn is coefficients to a polynomial, not a vector in space; it doesn't make sense for it to be normalized. This was added in f475e367f2
.
2023-03-04 09:13:33 -08:00
Pokechu22
35d02401d9
Indent lighting code and use proper local variables
2023-03-04 09:13:33 -08:00
Pokechu22
bbe682013d
Remove ldir == 0 special-case
...
This special-case was added in 06d1b8c63a
, but it would only trigger if the light's position exactly matches a vertex's position, which seems fairly unlikely (and I don't think has been hardware tested). It also only exists in the no attenuation case, which seems odd (it was initially considered (in 08e3ade696db9dc85f1a329a7706cecea1285987) to apply it to all cases, but that wasn't done for unclear reasons). Plus, normalizing a zero-length vector produces an undefined result.
2023-03-04 09:13:33 -08:00
Pokechu22
40f548d7e0
Refactor LightingShaderGen for readability
2023-03-04 09:13:33 -08:00
Pokechu22
0d0fd31075
Stop normalizing light directions
...
This normalization was added in 02ac5e95c8
(and changed to use floats in 4bf031c064
). However, this normalization introduces NaN values in some cases, which is causing problems for the version of Mesa in use on FifoCI (currently 20.3.5). Although Mesa's NaN behavior is corrected by b3f3287eac
(21.2.0), FifoCI is currently stuck with the older version.
2023-03-04 09:13:33 -08:00
JosJuice
95ce41ac56
Merge pull request #11399 from JosJuice/jit-one-stack
...
Jit: Don't use a second stack
2023-03-03 22:27:16 +01:00
Pokechu22
a93b5a4a35
Merge pull request #10908 from Minty-Meeo/unlikely-assert
...
[[unlikely]] ASSERT and minor ASSERT usage changes
2023-03-02 21:26:55 -08:00
Minty-Meeo
bf079d6d3a
[[unlikely]] ASSERT
...
and other ASSERT usage changes
2023-03-02 19:54:15 -06:00
Mai
6361586a04
Merge pull request #11582 from Pokechu22/software-crash-on-startup
...
Software: Fix regressions from "Kill Renderer"
2023-03-02 15:13:00 -05:00
Mai
ab2f8d3475
Merge pull request #11607 from AdmiralCurtiss/sd-progress
...
Qt/WiiPane: Add progress window for SD card conversion.
2023-03-02 15:08:18 -05:00
Mai
6fcec80eb0
Merge pull request #11605 from JosJuice/android-mappings-button
...
Android: Add a button for accessing controller mappings
2023-03-02 15:06:47 -05:00
Mai
cbbc518bc4
Merge pull request #11612 from iwubcode/custom_texture_data
...
VideoCommon: move hirestexture data to reusable class called CustomTextureData
2023-03-02 15:05:46 -05:00
Mai
78e8669bac
Merge pull request #11614 from t895/kotlin-cheats
...
Android: Convert Cheats Activity to Kotlin
2023-03-02 15:04:19 -05:00
Mai
1b7969bc62
Merge pull request #11615 from t895/kotlin-riivolution
...
Android: Convert Riivolution Boot Activity to Kotlin
2023-03-02 15:03:43 -05:00
Mai
b9fd7e7bd4
Merge pull request #11616 from t895/kotlin-skylanders
...
Android: Convert Skylanders code to Kotlin
2023-03-02 15:03:18 -05:00
Mai
5d00bc088a
Merge pull request #11619 from t895/kotlin-convert
...
Android: Convert Convert Activity to Kotlin
2023-03-02 15:02:45 -05:00
Pokechu22
9cdc0aca9b
Software: Fix "Auto-Adjust Window Size"
...
This also needs to be handled on the software renderer path.
2023-03-02 11:08:49 -08:00
Pokechu22
78428dd8db
Software: Fix crash on startup when using "Compile Shaders Before Starting"
...
When that setting is enabled, m_xfb_entry is initially not present (during the phase where a shader compilation progress bar would be shown). The main path checks for m_xfb_entry, but the software renderer fallback path didn't.
Fixes another aspect of https://bugs.dolphin-emu.org/issues/13172 .
2023-03-02 11:08:49 -08:00
Pokechu22
4a2d3c83c7
Software: Implement GetSurfaceInfo()
...
Before, it used a fallback where it returned a default object, where the width and height were set to 0. Presenter::Initialize() used GetSurfaceInfo to set the backbuffer size, then used that size when initializing the on-screen UI (even for the software renderer, where the on-screen UI isn't currently present), which meant that ImGui got a window size of 0 and thus resulted in a failed assertion.
Although BindBackbuffer checks for size changes, it doesn't help because ImGui has already been initialized, and the size hasn't actually changed since initialization occured.
Fixes one aspect of https://bugs.dolphin-emu.org/issues/13172 .
2023-03-02 11:08:49 -08:00
JosJuice
96deb2d897
Android: Hide controller mappings button when controller type is None
...
Also removed the make_sure_continuous_scan_enabled message.
It doesn't make sense with the new UX.
2023-03-02 18:25:10 +01:00
Charles Lombardo
2067c8eed1
Android: Convert ConvertActivity to Kotlin
2023-03-02 01:54:46 -05:00
Charles Lombardo
fb432dd58a
Android: Convert ConvertFragment to Kotlin
2023-03-02 01:54:46 -05:00
Charles Lombardo
7efb672be6
Android: Convert SkylanderSlotAdapter to Kotlin
2023-03-01 17:32:19 -05:00
Charles Lombardo
36f1315513
Android: Convert SkylanderSlot to Kotlin
2023-03-01 17:32:07 -05:00
Charles Lombardo
bbc1951afb
Android: Convert SkylanderConfig to Kotlin
2023-03-01 17:32:07 -05:00
Charles Lombardo
71e82d76b5
Android: Convert SkylanderPair to Kotlin
2023-03-01 17:13:42 -05:00
Charles Lombardo
85b30f198b
Android: Convert Skylander to Kotlin
2023-03-01 17:13:01 -05:00
Charles Lombardo
4045e213ba
Android: Convert RiivolutionAdapter to Kotlin
2023-03-01 14:39:18 -05:00
Charles Lombardo
df21663d4c
Android: Convert RiivolutionBootActivity to Kotlin
2023-03-01 14:38:59 -05:00
Charles Lombardo
79d0ff55d2
Android: Convert RiivolutionItem to Kotlin
2023-03-01 14:38:37 -05:00
Charles Lombardo
e37503675a
Android: Convert RiivolutionViewHolder to Kotlin
2023-03-01 14:38:19 -05:00
Charles Lombardo
ec7b811de3
Android: Convert RiivolutionPatches to Kotlin
2023-03-01 14:38:02 -05:00
Charles Lombardo
3935449ca0
Android: Convert TwoPaneOnBackPressedCallback to Kotlin
2023-03-01 13:47:28 -05:00
Charles Lombardo
6bc4ae7438
Android: Convert SettingDisabledWarningFragment to Kotlin
2023-03-01 13:41:55 -05:00
Charles Lombardo
53d404c5a0
Android: Convert HeaderViewHolder to Kotlin
2023-03-01 13:41:02 -05:00
Charles Lombardo
58b7b80902
Android: Convert GraphicsModsDisabledWarningFragment to Kotlin
2023-03-01 13:40:48 -05:00
Charles Lombardo
a8da5902bb
Android: Convert CheatViewHolder to Kotlin
2023-03-01 13:40:28 -05:00
Charles Lombardo
25fb3218d9
Android: Convert CheatsDisabledWarningFragment to Kotlin
2023-03-01 13:40:08 -05:00
Charles Lombardo
fcfde12c52
Android: Convert CheatsAdapter to Kotlin
2023-03-01 13:39:49 -05:00
Charles Lombardo
23d9def613
Android: Convert CheatsActivity to Kotlin
2023-03-01 13:39:23 -05:00
Charles Lombardo
3bcc4a0a59
Android: Convert CheatListFragment to Kotlin
2023-03-01 13:39:07 -05:00