Andreas Kling
67a867d60d
LibWeb: Avoid dynamic_cast in DOM::Document::is_decoded_svg()
2025-04-18 10:37:08 +02:00
Andreas Kling
c5bbd5f4fa
LibWeb: Avoid dynamic_cast in relevant_agent()
...
There's only ever one kind of JS::VM::CustomData in play anyway.
2025-04-18 10:36:04 +02:00
Andreas Kling
88ed7860f2
LibWeb: Skip dynamic_cast in CSSRGB after we already did a type check
2025-04-18 10:33:19 +02:00
Andreas Kling
c77724f748
LibJS+LibWeb: Add JS::Object::fast_is<T> helpers for some LibWeb types
...
These are slightly unfortunate as we're crossing the library boundary,
but there's precedent with Object::is_dom_node(), and these are just
knocking down a few more items that were showing up in profiles.
2025-04-18 10:31:28 +02:00
Andreas Kling
f065dfb558
LibWeb: Avoid double dynamic_cast in parent_element_for_event_dispatch()
2025-04-18 10:29:39 +02:00
Andreas Kling
9a4a76ac5c
LibWeb: Add more fast_is<T> helpers for layout and paintable nodes
2025-04-18 10:28:46 +02:00
Andreas Kling
0f2dd7039c
LibWeb: Add more fast_is<T> helpers for DOM::Node subclasses
2025-04-18 10:27:59 +02:00
Andreas Kling
9dda0fa662
LibWeb: Add fast_is<T> helpers for Navigable & TraversableNavigable
2025-04-18 10:25:56 +02:00
Andreas Kling
425101d98e
LibJS+LibWeb: Add fast_is<T> helpers for Realm::HostDefined class family
2025-04-18 10:24:45 +02:00
Andreas Kling
1a80833665
LibJS+LibWeb: Add fast_is<T> helpers for HTML::Script class family
2025-04-18 10:23:02 +02:00
Andreas Kling
bbbf83ef12
LibWeb: Avoid dynamic_cast in EventTarget initialization
...
Let's use a virtual to tell if something uses the
WindowOrWorkerGlobalScope mixin instead.
2025-04-18 10:21:36 +02:00
Andreas Kling
fdfdf6a4ca
LibJS: Add a bunch of fast_is<T> helpers for commonly checked types
...
Based on what was hitting dynamic_cast<T> on Speedometer.
2025-04-18 10:18:40 +02:00
sideshowbarker
b88fddbf47
FAQ: Add question and answer about ad blocker
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run
2025-04-17 20:00:51 +02:00
Andreas Kling
832b0a0ace
LibWeb: Invalidate style when HTMLDialogElement modal state changes
...
This fixes Layout/input/dialog-open-modal.html which began flaking
super hard after the preceding commits that reduced style invalidation
for focus-related pseudo class selectors.
2025-04-17 19:45:55 +02:00
Andreas Kling
8d51c41a42
LibWeb: Remove no-longer-used StyleInvalidationReasons :^)
2025-04-17 19:45:55 +02:00
Andreas Kling
55ab8ff539
LibWeb: Use optimized invalidation for :active pseudo class
2025-04-17 19:45:55 +02:00
Andreas Kling
6da48c60ca
LibWeb: Use optimized invalidation for target-related pseudo classes
2025-04-17 19:45:55 +02:00
Andreas Kling
414e0cc930
LibWeb: Use optimized invalidation for focus-related pseudo classes
2025-04-17 19:45:55 +02:00
Andreas Kling
e1777f6e79
LibWeb: Make :hover invalidation logic reusable for all pseudo classes
...
We achieve this by keeping track of all checked pseudo class selectors
in the SelectorEngine code. We also give StyleComputer per-pseudo-class
rule caches.
2025-04-17 19:45:55 +02:00
Andreas Kling
ed35f9e7c2
LibWeb: Remove unused MatchingRule::must_be_hovered flag
...
This was a vestige from an earlier version of hover selector work
avoidance optimizations.
2025-04-17 19:45:55 +02:00
Timothy Flynn
60f667fc5a
LibWeb: Use (de)serialization with transfer AOs for structured cloning
...
This is important, for example, to detach transferred array buffers.
2025-04-17 12:13:13 -04:00
Timothy Flynn
5eab109d85
LibWeb: Update structured deserialization to accept its target realm
...
This is a formal parameter to this AO in the spec.
2025-04-17 12:13:13 -04:00
Timothy Flynn
0c309d4660
LibWeb: Import detached ReadableStream buffer tests
2025-04-17 12:13:13 -04:00
Timothy Flynn
cef714732e
Documentation: Remove now-obsolete patch from Servo's DevTools parser
...
They have fixed the exception mentioned here, but the script still has
trouble displaying all live-captured packets.
2025-04-17 12:12:50 -04:00
Timothy Flynn
83b6803b32
Documentation: Expand DevTools notes on creating a new Firefox profile
...
Add a command to create a new Firefox profile, and add `--new-instance`
to the command line when using it.
2025-04-17 12:12:50 -04:00
Vishal Biswas
eb165554e1
LibWeb: Use double type in ProgressEvent
...
loaded and total should be double as per spec
https://xhr.spec.whatwg.org/#progressevent
2025-04-17 08:28:47 -04:00
Vishal Biswas
d56f6805d3
LibWeb: Mimic if-condition from spec
...
https://xhr.spec.whatwg.org/#dom-xmlhttprequest-abort
2025-04-17 08:28:47 -04:00
Timothy Flynn
5e9a11b13d
LibWebView: Respect autocomplete response Content-Encoding headers
...
For example, Google uses ISO-8859-1 encoding. This patch allows us to
decode such responses, falling back to UTF-8 if a Content-Type was not
specified or could not be parsed. We should also now handle if decoding
fails, rather than crashing inside JsonParser.
2025-04-17 07:51:43 -04:00
Tim Ledbetter
ca200142e9
LibWeb: Don't construct stylesheet when modifying CSSStyleSheet
rules
...
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run
Previously, `CSSStyleSheet.replace()` and `CSSStyleSheet.replaceSync()`
parsed the given CSS text into a temporary stylesheet object, from
which a list of rules was extracted. Doing this had the unintended
side-effect that a fetch request would be started if the given CSS text
referenced any external resources. This fetch request would cause a
crash, since the temporary stylesheet object didn't set the constructed
flag, or constructor document. We now parse the given CSS text as a
list of rules without constructing a temporary stylesheet.
2025-04-16 22:03:12 +01:00
Timothy Flynn
955f6fc9cb
LibWeb: Fulfill TransformStream promises with the correct "reason"
...
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run
We need to use the reason provided to the abort algorithm, not the one
from the resolved cancel promise (which will be undefined).
2025-04-16 13:15:33 -04:00
Timothy Flynn
f6438e83b8
LibWeb: Import TransformStreams reentrant strategies tests
2025-04-16 13:15:33 -04:00
Timothy Flynn
1673f6783c
LibWeb: Import TransformStream error tests
2025-04-16 13:15:33 -04:00
Andrew Kaster
ad00306daf
AK: Disallow constness laundering in RefPtr and NonnullRefPtr
...
This is a re-application of 3c7a0ef1ac
Co-Authored-By: Andreas Kling <andreas@ladybird.org>
2025-04-16 10:41:44 -06:00
Andrew Kaster
5e1b3cdeb9
LibGfx: Pass MetalContext in an NNRP in SkiaBackendContext
...
Previously we were move()-ing an lvalue reference, which causes
issues with upcoming RefPtr const correctness changes.
2025-04-16 10:41:44 -06:00
Andrew Kaster
02afbf3285
WebDriver: Access global sessions mutably when finding sessions
...
We grab RefPtr to non-const for the sessions within, so we can't call
const get() on the global maps. That would return a const reference.
2025-04-16 10:41:44 -06:00
Andrew Kaster
ea68944149
LibWeb: Store LibGfx objects in RefPtr to const for draw commands
2025-04-16 10:41:44 -06:00
Andrew Kaster
c36c7ed67b
LibWeb: Launder const in CSS::Selector::absolutized when returning self
...
This const method tries to return a RefPtr to non-const self. That's
not kosher, but fixing it needs some architecture work.
2025-04-16 10:41:44 -06:00
Andrew Kaster
16e764ddb6
LibWasm: Store function references' source module in RefPtr to const
2025-04-16 10:41:44 -06:00
Andrew Kaster
c471faee10
LibJS: Launder const in the parser where required with strict RefPtrs
...
These places should be updated to not require this hackery, but pulling
on this thread involves touching almost every method in the parser.
2025-04-16 10:41:44 -06:00
Andrew Kaster
59b1fb23a9
LibJS: Remove unused InstructionStreamIterator::source_code getter
2025-04-16 10:41:44 -06:00
Andrew Kaster
703abac9c8
AK: Add const_cast escape hatch for converting const T& to RefPtr<T>
...
There are parts of the codebase where properly const-correctifying the
the code would be a giant spaghetti mess, so add this loud workaround
to defer the refactoring for later.
2025-04-16 10:41:44 -06:00
Andrew Kaster
6ff0373556
UI: Pass parent WebView by non-const ref when creating children
...
We need to call non-const methods on this guy and access its members in
a non-const way.
2025-04-16 10:41:44 -06:00
Andrew Kaster
5c4b65996e
UI/Qt: Store TVG Image Data in a RefPtr to const
...
We don't need to mutate this data after it's loaded.
2025-04-16 10:41:44 -06:00
Andrew Kaster
4b7f4aef10
LibWeb: Pass RefPtr to const to ClippableAndScrollable setters
...
We were already storing the ClipFrame and ScrollFrame in RefPtr to const
but we were passing them as RefPtr to non-const to the setters.
2025-04-16 10:41:44 -06:00
Andrew Kaster
280ae45210
LibWeb: Pass ImageData as non-const to CanvasImageData mixin methods
...
CRC2D needs to manipulate the ImageData object in put_image_data()
2025-04-16 10:41:44 -06:00
Andrew Kaster
91b549f797
LibGfx+LibWebView+UI: Store Gfx::Bitmap in RefPtr to const
2025-04-16 10:41:44 -06:00
Andrew Kaster
be2dd91289
LibGfx+LibWeb: Store Typeface and Font-related types in RefPtr to const
2025-04-16 10:41:44 -06:00
Andrew Kaster
ffd0259bef
LibGfx: Store Core::Resources in RefPtr to const
2025-04-16 10:41:44 -06:00
Andrew Kaster
d1f6f5649e
LibWeb: Make storage of CSS::CalculationNodes const-correct
...
Now we consistently use `RefPtr<CalculationNode const>` for all
CalculationNodes.
2025-04-16 10:41:44 -06:00
Andrew Kaster
6d11414957
LibWeb: Make storage of CSS::StyleValues const-correct
...
Now we consistently use `RefPtr<StyleValue const>` for all StyleValues.
2025-04-16 10:41:44 -06:00